Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Side by Side Diff: tools/telemetry/telemetry/page/page_test.py

Issue 661303002: Revert of [Telemetry] Set the number of attempts to retry a test if browser or tab crash to 1 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « tools/telemetry/telemetry/page/page_runner_unittest.py ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2012 The Chromium Authors. All rights reserved. 1 # Copyright 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 from telemetry.core import command_line 5 from telemetry.core import command_line
6 from telemetry.page import test_expectations 6 from telemetry.page import test_expectations
7 from telemetry.page.actions import action_runner as action_runner_module 7 from telemetry.page.actions import action_runner as action_runner_module
8 8
9 9
10 class Failure(Exception): 10 class Failure(Exception):
(...skipping 115 matching lines...) Expand 10 before | Expand all | Expand 10 after
126 return self._close_tabs_before_run 126 return self._close_tabs_before_run
127 127
128 @close_tabs_before_run.setter 128 @close_tabs_before_run.setter
129 def close_tabs_before_run(self, close_tabs): 129 def close_tabs_before_run(self, close_tabs):
130 self._close_tabs_before_run = close_tabs 130 self._close_tabs_before_run = close_tabs
131 131
132 @property 132 @property
133 def attempts(self): 133 def attempts(self):
134 """Maximum number of times test will be attempted.""" 134 """Maximum number of times test will be attempted."""
135 # Do NOT override this method (crbug.com/422339). 135 # Do NOT override this method (crbug.com/422339).
136 return 1 136 return 3
137 137
138 @property 138 @property
139 def max_failures(self): 139 def max_failures(self):
140 """Maximum number of failures allowed for the page set.""" 140 """Maximum number of failures allowed for the page set."""
141 return self._max_failures 141 return self._max_failures
142 142
143 @max_failures.setter 143 @max_failures.setter
144 def max_failures(self, count): 144 def max_failures(self, count):
145 self._max_failures = count 145 self._max_failures = count
146 146
(...skipping 158 matching lines...) Expand 10 before | Expand all | Expand 10 after
305 305
306 def IsExiting(self): 306 def IsExiting(self):
307 return self._exit_requested 307 return self._exit_requested
308 308
309 def RequestExit(self): 309 def RequestExit(self):
310 self._exit_requested = True 310 self._exit_requested = True
311 311
312 @property 312 @property
313 def action_name_to_run(self): 313 def action_name_to_run(self):
314 return self._action_name_to_run 314 return self._action_name_to_run
OLDNEW
« no previous file with comments | « tools/telemetry/telemetry/page/page_runner_unittest.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698