media/midi/midi_manager_usb_unittest.cc - Issue 661163004: Standardize usage of virtual/override/final specifiers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/midi/midi_manager_usb_unittest.cc

Issue 661163004: Standardize usage of virtual/override/final specifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: media/midi/midi_manager_usb_unittest.cc

diff --git a/media/midi/midi_manager_usb_unittest.cc b/media/midi/midi_manager_usb_unittest.cc

index 5fbaa1b7b6718f83ad905156af4fc8a1f1423e10..4df64a62dcb43823847eab161597ab0f6c8c361d 100644

--- a/media/midi/midi_manager_usb_unittest.cc

+++ b/media/midi/midi_manager_usb_unittest.cc

@@ -159,7 +159,7 @@ class MidiManagerUsbTest : public ::testing::Test {

factory_ = factory.get();

manager_.reset(new MidiManagerUsbForTesting(factory.Pass()));

}

- virtual ~MidiManagerUsbTest() {

+ ~MidiManagerUsbTest() override {

std::string leftover_logs = logger_.TakeLog();

if (!leftover_logs.empty()) {

ADD_FAILURE() << "Log should be empty: " << leftover_logs;

« no previous file with comments | « media/midi/midi_manager_unittest.cc ('k') | media/mojo/services/renderer_unittest.cc » ('j') | no next file with comments »