Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(472)

Side by Side Diff: media/midi/midi_manager_usb_unittest.cc

Issue 661163004: Standardize usage of virtual/override/final specifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « media/midi/midi_manager_unittest.cc ('k') | media/mojo/services/renderer_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "media/midi/midi_manager_usb.h" 5 #include "media/midi/midi_manager_usb.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "base/message_loop/message_loop.h" 9 #include "base/message_loop/message_loop.h"
10 #include "base/run_loop.h" 10 #include "base/run_loop.h"
(...skipping 141 matching lines...) Expand 10 before | Expand all | Expand 10 after
152 DISALLOW_COPY_AND_ASSIGN(MidiManagerUsbForTesting); 152 DISALLOW_COPY_AND_ASSIGN(MidiManagerUsbForTesting);
153 }; 153 };
154 154
155 class MidiManagerUsbTest : public ::testing::Test { 155 class MidiManagerUsbTest : public ::testing::Test {
156 public: 156 public:
157 MidiManagerUsbTest() : message_loop_(new base::MessageLoop) { 157 MidiManagerUsbTest() : message_loop_(new base::MessageLoop) {
158 scoped_ptr<TestUsbMidiDeviceFactory> factory(new TestUsbMidiDeviceFactory); 158 scoped_ptr<TestUsbMidiDeviceFactory> factory(new TestUsbMidiDeviceFactory);
159 factory_ = factory.get(); 159 factory_ = factory.get();
160 manager_.reset(new MidiManagerUsbForTesting(factory.Pass())); 160 manager_.reset(new MidiManagerUsbForTesting(factory.Pass()));
161 } 161 }
162 virtual ~MidiManagerUsbTest() { 162 ~MidiManagerUsbTest() override {
163 std::string leftover_logs = logger_.TakeLog(); 163 std::string leftover_logs = logger_.TakeLog();
164 if (!leftover_logs.empty()) { 164 if (!leftover_logs.empty()) {
165 ADD_FAILURE() << "Log should be empty: " << leftover_logs; 165 ADD_FAILURE() << "Log should be empty: " << leftover_logs;
166 } 166 }
167 } 167 }
168 168
169 protected: 169 protected:
170 void Initialize() { 170 void Initialize() {
171 client_.reset(new FakeMidiManagerClient(&logger_)); 171 client_.reset(new FakeMidiManagerClient(&logger_));
172 manager_->StartSession(client_.get()); 172 manager_->StartSession(client_.get());
(...skipping 187 matching lines...) Expand 10 before | Expand all | Expand 10 after
360 "data = 0x90 0x45 0x7f\n" 360 "data = 0x90 0x45 0x7f\n"
361 "MidiManagerClient::ReceiveMidiData port_index = 0 " 361 "MidiManagerClient::ReceiveMidiData port_index = 0 "
362 "data = 0xf0 0x00 0x01\n" 362 "data = 0xf0 0x00 0x01\n"
363 "MidiManagerClient::ReceiveMidiData port_index = 0 data = 0xf7\n", 363 "MidiManagerClient::ReceiveMidiData port_index = 0 data = 0xf7\n",
364 logger_.TakeLog()); 364 logger_.TakeLog());
365 } 365 }
366 366
367 } // namespace 367 } // namespace
368 368
369 } // namespace media 369 } // namespace media
OLDNEW
« no previous file with comments | « media/midi/midi_manager_unittest.cc ('k') | media/mojo/services/renderer_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698