Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 661043006: history: break <label> relationship between time and delete checkbox. (Closed)

Created:
6 years, 2 months ago by Dan Beam
Modified:
6 years, 2 months ago
Reviewers:
*dmazzoni
CC:
chromium-reviews, Patrick Dubroy, pam+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

history: break <label> relationship between time and delete checkbox. Clicking anywhere in an entry already toggles the checkbox and this was just messing up VoiceOver spoken feedback. Also add aria-label to satisfy a11y audit and make voice feedback better. R=dmazzoni@chromium.org BUG=385344 Committed: https://crrev.com/54249ff53efa22453631d45b55da7dd744cac78e Cr-Commit-Position: refs/heads/master@{#300282}

Patch Set 1 #

Patch Set 2 : aria-label to satisfy a11y audit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M chrome/browser/resources/history/history.js View 1 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Dan Beam
6 years, 2 months ago (2014-10-18 02:56:56 UTC) #2
dmazzoni
lgtm
6 years, 2 months ago (2014-10-20 16:30:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/661043006/20001
6 years, 2 months ago (2014-10-20 16:30:30 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 2 months ago (2014-10-20 17:03:12 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-20 17:04:03 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/54249ff53efa22453631d45b55da7dd744cac78e
Cr-Commit-Position: refs/heads/master@{#300282}

Powered by Google App Engine
This is Rietveld 408576698