Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1831)

Unified Diff: chrome/browser/resources/history/history.js

Issue 661043006: history: break <label> relationship between time and delete checkbox. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: aria-label to satisfy a11y audit Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/history/history.js
diff --git a/chrome/browser/resources/history/history.js b/chrome/browser/resources/history/history.js
index 5d91c4dace5df7710f1c267d2cc925e3bbc7ca0d..6c18a61a5bd88413d3673a357f6123659fb06e2d 100644
--- a/chrome/browser/resources/history/history.js
+++ b/chrome/browser/resources/history/history.js
@@ -183,7 +183,7 @@ Visit.prototype.getResultDOM = function(propertyBag) {
var useMonthDate = propertyBag.useMonthDate || false;
var focusless = propertyBag.focusless || false;
var node = createElementWithClassName('li', 'entry');
- var time = createElementWithClassName('label', 'time');
+ var time = createElementWithClassName('span', 'time');
var entryBox = createElementWithClassName('div', 'entry-box');
var domain = createElementWithClassName('div', 'domain');
@@ -196,9 +196,10 @@ Visit.prototype.getResultDOM = function(propertyBag) {
var checkbox = document.createElement('input');
checkbox.type = 'checkbox';
checkbox.id = 'checkbox-' + this.id_;
+ checkbox.setAttribute('aria-label',
+ loadTimeData.getString('removeFromHistory'));
checkbox.time = this.date.getTime();
checkbox.addEventListener('click', checkboxClicked);
- time.setAttribute('for', checkbox.id);
entryBox.appendChild(checkbox);
if (focusless)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698