Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(555)

Issue 660903002: Remove obsolete SkRecording. (Closed)

Created:
6 years, 2 months ago by mtklein_C
Modified:
6 years, 2 months ago
Reviewers:
mtklein, robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Remove obsolete SkRecording. Can land after https://codereview.chromium.org/664583002/ does. BUG=skia: Only API removed. TBR=reed@google.com Committed: https://skia.googlesource.com/skia/+/a71aee6afd209617f44ac6e76dcc024baab69d18

Patch Set 1 #

Patch Set 2 : clean up #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -151 lines) Patch
M gyp/core.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M gyp/tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download
D include/record/SkRecording.h View 1 chunk +0 lines, -75 lines 0 comments Download
D src/core/SkRecording.cpp View 1 chunk +0 lines, -44 lines 0 comments Download
D tests/RecordingTest.cpp View 1 chunk +0 lines, -29 lines 0 comments Download
M tests/RecordingXfermodeTest.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
mtklein
6 years, 2 months ago (2014-10-16 21:38:02 UTC) #2
robertphillips
lgtm
6 years, 2 months ago (2014-10-17 12:24:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/660903002/1
6 years, 2 months ago (2014-10-17 15:40:48 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu13.10-GCE-NoGPU-x86_64-Debug-Trybot on client.skia (http://build.chromium.org/p/client.skia/builders/Test-Ubuntu13.10-GCE-NoGPU-x86_64-Debug-Trybot/builds/101) Test-Ubuntu13.10-GCE-NoGPU-x86_64-Release-Shared-Trybot on client.skia (http://build.chromium.org/p/client.skia/builders/Test-Ubuntu13.10-GCE-NoGPU-x86_64-Release-Shared-Trybot/builds/98)
6 years, 2 months ago (2014-10-17 15:42:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/660903002/20001
6 years, 2 months ago (2014-10-20 13:38:29 UTC) #10
commit-bot: I haz the power
6 years, 2 months ago (2014-10-20 13:45:03 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as a71aee6afd209617f44ac6e76dcc024baab69d18

Powered by Google App Engine
This is Rietveld 408576698