Temporarily disable flash parameter configuration.

Temporarily disable flash parameter configuration.

The flash parameters need to come after the BCT file in the
cbootimage config file (otherwise they are clobbered by the
BCT's values).  But once they are moved to the correct location
the resulting image doesn't boot.  This change means that
we can only boot from flash devices that are already specified
in the BCT file.

BUG=chromium-os:11981
TEST=Build and Boot from spi on Kaen.

Change-Id: Ic5e92e8057c56bb5c5e2f0e3ca191806c56859f0

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=f47f79a

[vb, 2011-03-03 03:55:24]

http://codereview.chromium.org/6609004/diff/1/host/cros_sign_bootstub
File host/cros_sign_bootstub (right):

http://codereview.chromium.org/6609004/diff/1/host/cros_sign_bootstub#newcode55
host/cros_sign_bootstub:55: echo ""
I am not sure I follow - is it right that essentially all what happens around
these lines is adding the comment in lines 57..61 and moving one empty echoing
statement and adding another one?

Are these empty echoing statement moves necessary? If not - please remove the
unnecessary changes.

http://codereview.chromium.org/6609004/diff/1/host/cros_sign_bootstub#newcode57
host/cros_sign_bootstub:57: # TODO(robotboy): This needs to be added back in to
support selecting the
Please open a tracker entry for this problem and include the pointer to the new
entry in the CL description.

[robotboy, 2011-03-03 17:53:33]

Done, PTAL.

Thanks,
    Anton

http://codereview.chromium.org/6609004/diff/1/host/cros_sign_bootstub
File host/cros_sign_bootstub (right):

http://codereview.chromium.org/6609004/diff/1/host/cros_sign_bootstub#newcode55
host/cros_sign_bootstub:55: echo ""
On 2011/03/03 03:55:24, vb wrote:
> I am not sure I follow - is it right that essentially all what happens around
> these lines is adding the comment in lines 57..61 and moving one empty echoing
> statement and adding another one?
> 
> Are these empty echoing statement moves necessary? If not - please remove the
> unnecessary changes. 

Done.

http://codereview.chromium.org/6609004/diff/1/host/cros_sign_bootstub#newcode57
host/cros_sign_bootstub:57: # TODO(robotboy): This needs to be added back in to
support selecting the
On 2011/03/03 03:55:24, vb wrote:
> Please open a tracker entry for this problem and include the pointer to the
new
> entry in the CL description.

Done.

[vb, 2011-03-03 18:03:56]

LGTM

Sorry, I was not clear with my previous comments - I meant to
say that if there were no formatting changes this would be a
more obvious Cl to review.

Not a big deal either way, I'll leave it to your discretion.

[robotboy, 2011-03-03 18:07:47]

Yes, I tried to minimize the formatting changes.  The empty echo at the top
of the file wen't away because the cat went away.  I suppose I should have
left the formatting of the variables alone, that would have made it smaller,
sorry about that, I'll be more careful next time.

Thanks,
    Anton

On Thu, Mar 3, 2011 at 10:03 AM, <vbendeb@chromium.org> wrote:

> LGTM
>
> Sorry, I was not clear with my previous comments - I meant to
> say that if there were no formatting changes this would be a
> more obvious Cl to review.
>
> Not a big deal either way, I'll leave it to your discretion.
>
>
> http://codereview.chromium.org/6609004/
>