Remove isSyncDatabase in WebDatabaseObserver [1/3]

public/platform/WebDatabaseObserver.h

Index: public/platform/WebDatabaseObserver.h
diff --git a/public/platform/WebDatabaseObserver.h b/public/platform/WebDatabaseObserver.h
index 59da49148d482953a03503f0bd7b8efb6fcfbdcb..f5be5b6c7ea73d4250e80addec68f4ca02630f42 100644
--- a/public/platform/WebDatabaseObserver.h
+++ b/public/platform/WebDatabaseObserver.h
@@ -53,6 +53,50 @@ public:
     virtual void reportOpenDatabaseResult(
         const WebString& databaseIdentifier,
         const WebString& databaseName,
+        int errorSite, int webSqlErrorCode, int sqliteErrorCode)

[Mike West, 2014/10/28 10:43:14]

Nit: This is strange formatting; is it what `git cl format` gives you?

+    {
+        reportOpenDatabaseResult(databaseIdentifier, databaseName, false, errorSite, webSqlErrorCode, sqliteErrorCode);
+    }
+    virtual void reportChangeVersionResult(
+        const WebString& databaseIdentifier,
+        const WebString& databaseName,
+        int errorSite, int webSqlErrorCode, int sqliteErrorCode)
+    {
+        reportChangeVersionResult(databaseIdentifier, databaseName, false, errorSite, webSqlErrorCode, sqliteErrorCode);
+    }
+    virtual void reportStartTransactionResult(
+        const WebString& databaseIdentifier,
+        const WebString& databaseName,
+        int errorSite, int webSqlErrorCode, int sqliteErrorCode)
+    {
+        reportStartTransactionResult(databaseIdentifier, databaseName, false, errorSite, webSqlErrorCode, sqliteErrorCode);
+    }
+    virtual void reportCommitTransactionResult(
+        const WebString& databaseIdentifier,
+        const WebString& databaseName,
+        int errorSite, int webSqlErrorCode, int sqliteErrorCode)
+    {
+        reportCommitTransactionResult(databaseIdentifier, databaseName, false, errorSite, webSqlErrorCode, sqliteErrorCode);
+    }
+    virtual void reportExecuteStatementResult(
+        const WebString& databaseIdentifier,
+        const WebString& databaseName,
+        int errorSite, int webSqlErrorCode, int sqliteErrorCode)
+    {
+        reportExecuteStatementResult(databaseIdentifier, databaseName, false, errorSite, webSqlErrorCode, sqliteErrorCode);
+    }
+    virtual void reportVacuumDatabaseResult(
+        const WebString& databaseIdentifier,
+        const WebString& databaseName,
+        int sqliteErrorCode)
+    {
+        reportVacuumDatabaseResult(databaseIdentifier, databaseName, false, sqliteErrorCode);
+    }
+
+    // FIXME: Remove these functions if we don't use isSyncDatabase in chromium part.

[Mike West, 2014/10/28 10:43:14]

Nit: "Remove these functions once we no longeruse isSyncDatabase in Chromium."

+    virtual void reportOpenDatabaseResult(
+        const WebString& databaseIdentifier,
+        const WebString& databaseName,
         bool isSyncDatabase,
         int errorSite, int webSqlErrorCode, int sqliteErrorCode) { }
     virtual void reportChangeVersionResult(