Remove isSyncDatabase in WebDatabaseObserver [1/3]

public/platform/WebDatabaseObserver.h

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 35 matching lines @@
         unsigned long estimatedSize) = 0;
     virtual void databaseModified(
         const WebString& databaseIdentifier,
         const WebString& databaseName) = 0;
     virtual void databaseClosed(
         const WebString& databaseIdentifier,
         const WebString& databaseName) = 0;
     virtual void reportOpenDatabaseResult(
         const WebString& databaseIdentifier,
         const WebString& databaseName,
+        int errorSite, int webSqlErrorCode, int sqliteErrorCode)

[Mike West, 2014/10/28 10:43:14]

Nit: This is strange formatting; is it what `git cl format` gives you?

+    {
+        reportOpenDatabaseResult(databaseIdentifier, databaseName, false, errorSite, webSqlErrorCode, sqliteErrorCode);
+    }
+    virtual void reportChangeVersionResult(
+        const WebString& databaseIdentifier,
+        const WebString& databaseName,
+        int errorSite, int webSqlErrorCode, int sqliteErrorCode)
+    {
+        reportChangeVersionResult(databaseIdentifier, databaseName, false, errorSite, webSqlErrorCode, sqliteErrorCode);
+    }
+    virtual void reportStartTransactionResult(
+        const WebString& databaseIdentifier,
+        const WebString& databaseName,
+        int errorSite, int webSqlErrorCode, int sqliteErrorCode)
+    {
+        reportStartTransactionResult(databaseIdentifier, databaseName, false, errorSite, webSqlErrorCode, sqliteErrorCode);
+    }
+    virtual void reportCommitTransactionResult(
+        const WebString& databaseIdentifier,
+        const WebString& databaseName,
+        int errorSite, int webSqlErrorCode, int sqliteErrorCode)
+    {
+        reportCommitTransactionResult(databaseIdentifier, databaseName, false, errorSite, webSqlErrorCode, sqliteErrorCode);
+    }
+    virtual void reportExecuteStatementResult(
+        const WebString& databaseIdentifier,
+        const WebString& databaseName,
+        int errorSite, int webSqlErrorCode, int sqliteErrorCode)
+    {
+        reportExecuteStatementResult(databaseIdentifier, databaseName, false, errorSite, webSqlErrorCode, sqliteErrorCode);
+    }
+    virtual void reportVacuumDatabaseResult(
+        const WebString& databaseIdentifier,
+        const WebString& databaseName,
+        int sqliteErrorCode)
+    {
+        reportVacuumDatabaseResult(databaseIdentifier, databaseName, false, sqliteErrorCode);
+    }
+
+    // FIXME: Remove these functions if we don't use isSyncDatabase in chromium part.

[Mike West, 2014/10/28 10:43:14]

Nit: "Remove these functions once we no longeruse isSyncDatabase in Chromium."

+    virtual void reportOpenDatabaseResult(
+        const WebString& databaseIdentifier,
+        const WebString& databaseName,
         bool isSyncDatabase,
         int errorSite, int webSqlErrorCode, int sqliteErrorCode) { }
     virtual void reportChangeVersionResult(
         const WebString& databaseIdentifier,
         const WebString& databaseName,
         bool isSyncDatabase,
         int errorSite, int webSqlErrorCode, int sqliteErrorCode) { }
     virtual void reportStartTransactionResult(
         const WebString& databaseIdentifier,
         const WebString& databaseName,
@@ skipping 14 matching lines @@
         const WebString& databaseName,
         bool isSyncDatabase, int sqliteErrorCode) { }
 
 protected:
     ~WebDatabaseObserver() { }
 };
 
 } // namespace blink
 
 #endif // WebDatabaseObserver_h