Remove isSyncDatabase in WebDatabaseObserver [1/3]

public/platform/WebDatabaseObserver.h

Index: public/platform/WebDatabaseObserver.h
diff --git a/public/platform/WebDatabaseObserver.h b/public/platform/WebDatabaseObserver.h
index 59da49148d482953a03503f0bd7b8efb6fcfbdcb..a23c922a0b7091f5533579bc638fa81e16831618 100644
--- a/public/platform/WebDatabaseObserver.h
+++ b/public/platform/WebDatabaseObserver.h
@@ -37,8 +37,6 @@ class WebString;
 
 class WebDatabaseObserver {
 public:
-    // FIXME: |isSyncDatabse| arguments are alwyas |false|. We should remove them.
-
     virtual void databaseOpened(
         const WebString& databaseIdentifier,
         const WebString& databaseName,
@@ -53,6 +51,32 @@ public:
     virtual void reportOpenDatabaseResult(
         const WebString& databaseIdentifier,
         const WebString& databaseName,
+        int errorSite, int webSqlErrorCode, int sqliteErrorCode) { }

[kinuko, 2014/10/27 06:31:40]

Can't you call the corresponding old method here as its default impl instead of
calling these methods twice in the callsites?  Then later you can delete the
default impl and old methods after you override these in chromium.

+    virtual void reportChangeVersionResult(
+        const WebString& databaseIdentifier,
+        const WebString& databaseName,
+        int errorSite, int webSqlErrorCode, int sqliteErrorCode) { }
+    virtual void reportStartTransactionResult(
+        const WebString& databaseIdentifier,
+        const WebString& databaseName,
+        int errorSite, int webSqlErrorCode, int sqliteErrorCode) { }
+    virtual void reportCommitTransactionResult(
+        const WebString& databaseIdentifier,
+        const WebString& databaseName,
+        int errorSite, int webSqlErrorCode, int sqliteErrorCode) { }
+    virtual void reportExecuteStatementResult(
+        const WebString& databaseIdentifier,
+        const WebString& databaseName,
+        int errorSite, int webSqlErrorCode, int sqliteErrorCode) { }
+    virtual void reportVacuumDatabaseResult(
+        const WebString& databaseIdentifier,
+        const WebString& databaseName,
+        int sqliteErrorCode) { }
+
+    // FIXME: Remove these functions if we don't use isSyncDatabase in chromium part.
+    virtual void reportOpenDatabaseResult(
+        const WebString& databaseIdentifier,
+        const WebString& databaseName,
         bool isSyncDatabase,
         int errorSite, int webSqlErrorCode, int sqliteErrorCode) { }
     virtual void reportChangeVersionResult(