Remove isSyncDatabase in WebDatabaseObserver [1/3]

public/platform/WebDatabaseObserver.h

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 19 matching lines @@
 
 #ifndef WebDatabaseObserver_h
 #define WebDatabaseObserver_h
 
 namespace blink {
 
 class WebString;
 
 class WebDatabaseObserver {
 public:
-    // FIXME: |isSyncDatabse| arguments are alwyas |false|. We should remove them.
-
     virtual void databaseOpened(
         const WebString& databaseIdentifier,
         const WebString& databaseName,
         const WebString& databaseDisplayName,
         unsigned long estimatedSize) = 0;
     virtual void databaseModified(
         const WebString& databaseIdentifier,
         const WebString& databaseName) = 0;
     virtual void databaseClosed(
         const WebString& databaseIdentifier,
         const WebString& databaseName) = 0;
     virtual void reportOpenDatabaseResult(
         const WebString& databaseIdentifier,
         const WebString& databaseName,
+        int errorSite, int webSqlErrorCode, int sqliteErrorCode) { }

[kinuko, 2014/10/27 06:31:40]

Can't you call the corresponding old method here as its default impl instead of
calling these methods twice in the callsites?  Then later you can delete the
default impl and old methods after you override these in chromium.

+    virtual void reportChangeVersionResult(
+        const WebString& databaseIdentifier,
+        const WebString& databaseName,
+        int errorSite, int webSqlErrorCode, int sqliteErrorCode) { }
+    virtual void reportStartTransactionResult(
+        const WebString& databaseIdentifier,
+        const WebString& databaseName,
+        int errorSite, int webSqlErrorCode, int sqliteErrorCode) { }
+    virtual void reportCommitTransactionResult(
+        const WebString& databaseIdentifier,
+        const WebString& databaseName,
+        int errorSite, int webSqlErrorCode, int sqliteErrorCode) { }
+    virtual void reportExecuteStatementResult(
+        const WebString& databaseIdentifier,
+        const WebString& databaseName,
+        int errorSite, int webSqlErrorCode, int sqliteErrorCode) { }
+    virtual void reportVacuumDatabaseResult(
+        const WebString& databaseIdentifier,
+        const WebString& databaseName,
+        int sqliteErrorCode) { }
+
+    // FIXME: Remove these functions if we don't use isSyncDatabase in chromium part.
+    virtual void reportOpenDatabaseResult(
+        const WebString& databaseIdentifier,
+        const WebString& databaseName,
         bool isSyncDatabase,
         int errorSite, int webSqlErrorCode, int sqliteErrorCode) { }
     virtual void reportChangeVersionResult(
         const WebString& databaseIdentifier,
         const WebString& databaseName,
         bool isSyncDatabase,
         int errorSite, int webSqlErrorCode, int sqliteErrorCode) { }
     virtual void reportStartTransactionResult(
         const WebString& databaseIdentifier,
         const WebString& databaseName,
@@ skipping 14 matching lines @@
         const WebString& databaseName,
         bool isSyncDatabase, int sqliteErrorCode) { }
 
 protected:
     ~WebDatabaseObserver() { }
 };
 
 } // namespace blink
 
 #endif // WebDatabaseObserver_h