Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 660873002: Use scoped_ptr::Pass instead of scoped_ptr::PassAs<T>. (Closed)

Created:
6 years, 2 months ago by dcheng
Modified:
6 years, 2 months ago
Reviewers:
James Hawkins
CC:
cbentzel+watch_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, David Black, dhollowa+watch_chromium.org, donnd+watch_chromium.org, dougw+watch_chromium.org, extensions-reviews_chromium.org, gcasto+watchlist_chromium.org, Jered, jfweitz+watch_chromium.org, kinuko+fileapi, kmadhusu+watch_chromium.org, maniscalco+watch_chromium.org, melevin+watch_chromium.org, mkwst+watchlist_chromium.org, nhiroki, pam+watch_chromium.org, pvalenzuela+watch_chromium.org, samarth+watch_chromium.org, skanuj+watch_chromium.org, tfarina, tim+watch_chromium.org, tzik, zea+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Use scoped_ptr::Pass instead of scoped_ptr::PassAs<T>. BUG=423621 Committed: https://crrev.com/0f3f5253b1c96c34607d117a10e390def50cf1bc Cr-Commit-Position: refs/heads/master@{#299955}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -109 lines) Patch
M chrome/browser/net/chrome_network_delegate_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/evicted_domain_cookie_counter_unittest.cc View 2 chunks +2 lines, -8 lines 0 comments Download
M chrome/browser/net/sdch_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/spdyproxy/data_reduction_proxy_infobar_delegate.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/password_manager/password_manager_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/policy/policy_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prefs/profile_pref_store_manager.cc View 2 chunks +8 lines, -9 lines 0 comments Download
M chrome/browser/prefs/proxy_policy_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prefs/tracked/pref_hash_filter_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prefs/tracked/segregated_pref_store_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/printing/print_view_manager_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profile_resetter/automatic_profile_resetter_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/profiles/off_the_record_profile_io_data.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/profiles/profile_impl_io_data.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M chrome/browser/profiles/profile_io_data.cc View 3 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/safe_browsing/incident_reporting/incident_reporting_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/incident_reporting/last_download_finder_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/incident_reporting/preference_validation_delegate_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/search/suggestions/suggestions_service_factory.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/supervised_user/permission_request_creator_sync.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/supervised_user/supervised_user_browsertest.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/sync/glue/sync_backend_host_impl_unittest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/conflict_resolver_unittest.cc View 1 chunk +5 lines, -6 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/drive_backend_sync_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/list_changes_task_unittest.cc View 1 chunk +5 lines, -6 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/local_to_remote_syncer_unittest.cc View 1 chunk +5 lines, -6 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/register_app_task_unittest.cc View 1 chunk +5 lines, -7 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/remote_to_local_syncer_unittest.cc View 1 chunk +5 lines, -6 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_worker.cc View 1 chunk +1 line, -4 lines 0 comments Download
M chrome/browser/sync_file_system/remote_file_sync_service.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/extensions/extension_message_bubble_view.cc View 3 chunks +3 lines, -8 lines 0 comments Download
M chrome/browser/undo/undo_manager_test.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
dcheng
Fairly straightforward cleanup.
6 years, 2 months ago (2014-10-16 18:38:34 UTC) #2
James Hawkins
lgtm
6 years, 2 months ago (2014-10-16 18:41:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/660873002/1
6 years, 2 months ago (2014-10-16 18:44:19 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-16 19:37:16 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-16 19:37:44 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/0f3f5253b1c96c34607d117a10e390def50cf1bc
Cr-Commit-Position: refs/heads/master@{#299955}

Powered by Google App Engine
This is Rietveld 408576698