chrome/browser/search/suggestions/suggestions_service_factory.cc - Issue 660873002: Use scoped_ptr::Pass instead of scoped_ptr::PassAs<T>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/search/suggestions/suggestions_service_factory.cc

Issue 660873002: Use scoped_ptr::Pass instead of scoped_ptr::PassAs<T>. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/safe_browsing/incident_reporting/preference_validation_delegate_unittest.cc ('k') | chrome/browser/supervised_user/permission_request_creator_sync.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/search/suggestions/suggestions_service_factory.cc

diff --git a/chrome/browser/search/suggestions/suggestions_service_factory.cc b/chrome/browser/search/suggestions/suggestions_service_factory.cc

index 4a98018a237455c7f7f9303262aefff74013e4cd..6e680b4734f1ffb1e80c2a88d49afa13e2136a1c 100644

--- a/chrome/browser/search/suggestions/suggestions_service_factory.cc

+++ b/chrome/browser/search/suggestions/suggestions_service_factory.cc

@@ -74,9 +74,8 @@ KeyedService* SuggestionsServiceFactory::BuildServiceInstanceFor(

scoped_ptr<ImageFetcherImpl> image_fetcher(

new ImageFetcherImpl(the_profile->GetRequestContext()));

- scoped_ptr<ImageManager> thumbnail_manager(new ImageManager(

- image_fetcher.PassAs<ImageFetcher>(),

- db.PassAs<leveldb_proto::ProtoDatabase<ImageData> >(), database_dir));

+ scoped_ptr<ImageManager> thumbnail_manager(

+ new ImageManager(image_fetcher.Pass(), db.Pass(), database_dir));

return new SuggestionsService(

the_profile->GetRequestContext(), suggestions_store.Pass(),

thumbnail_manager.Pass(), blacklist_store.Pass());