Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 660783002: Implement reportValidity() (Closed)

Created:
6 years, 2 months ago by Bartek Nowierski
Modified:
6 years, 2 months ago
Reviewers:
keishi, tkent
CC:
blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org, arv+blink, Inactive
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Implement reportValidity() BUG=390486 TEST=Added layout tests based on checkValidity tests, with added focus check Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184177

Patch Set 1 #

Patch Set 2 : Pull & merge #

Patch Set 3 : Add focus checks to reportValidity layout tests #

Patch Set 4 : Pull #

Total comments: 6

Patch Set 5 : Apply keishi's comments + pull #

Total comments: 26

Patch Set 6 : Apply tkent's comments #

Total comments: 4

Patch Set 7 : Apply couple more tkent's comments + pull #

Unified diffs Side-by-side diffs Delta from patch set Stats (+385 lines, -45 lines) Patch
A LayoutTests/fast/forms/reportValidity-cancel.html View 1 2 3 4 1 chunk +54 lines, -0 lines 0 comments Download
A LayoutTests/fast/forms/reportValidity-cancel-expected.txt View 1 2 3 4 1 chunk +22 lines, -0 lines 0 comments Download
A + LayoutTests/fast/forms/reportValidity-handler-updates-dom.html View 1 2 3 4 5 chunks +40 lines, -18 lines 0 comments Download
A LayoutTests/fast/forms/reportValidity-handler-updates-dom-expected.txt View 1 2 3 4 1 chunk +38 lines, -0 lines 0 comments Download
A LayoutTests/fast/forms/reportValidity-invalid.html View 1 2 3 4 5 1 chunk +50 lines, -0 lines 0 comments Download
A LayoutTests/fast/forms/reportValidity-invalid-expected.txt View 1 2 3 4 5 1 chunk +29 lines, -0 lines 0 comments Download
A LayoutTests/fast/forms/reportValidity-valid.html View 1 2 3 4 5 1 chunk +57 lines, -0 lines 0 comments Download
A LayoutTests/fast/forms/reportValidity-valid-expected.txt View 1 2 3 4 5 1 chunk +25 lines, -0 lines 0 comments Download
M Source/core/html/HTMLButtonElement.idl View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/HTMLFieldSetElement.idl View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/HTMLFormControlElement.h View 1 2 3 4 5 6 1 chunk +4 lines, -1 line 0 comments Download
M Source/core/html/HTMLFormControlElement.cpp View 1 2 3 4 5 6 2 chunks +32 lines, -1 line 0 comments Download
M Source/core/html/HTMLFormElement.h View 1 2 chunks +3 lines, -2 lines 0 comments Download
M Source/core/html/HTMLFormElement.cpp View 1 2 3 4 5 5 chunks +21 lines, -23 lines 0 comments Download
M Source/core/html/HTMLFormElement.idl View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/HTMLInputElement.idl View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/HTMLKeygenElement.idl View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/HTMLObjectElement.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/HTMLObjectElement.idl View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/HTMLOutputElement.idl View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/HTMLSelectElement.idl View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/HTMLTextAreaElement.idl View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 19 (6 generated)
keishi
I think we want test if the validation message is visible or not. If you ...
6 years, 2 months ago (2014-10-21 08:20:15 UTC) #2
Bartek Nowierski
https://codereview.chromium.org/660783002/diff/60001/LayoutTests/fast/forms/reportValidity-004.html File LayoutTests/fast/forms/reportValidity-004.html (right): https://codereview.chromium.org/660783002/diff/60001/LayoutTests/fast/forms/reportValidity-004.html#newcode44 LayoutTests/fast/forms/reportValidity-004.html:44: shouldBe("backgroundOf('input-unset')", "focusedColor"); On 2014/10/21 08:20:14, keishi wrote: > We ...
6 years, 2 months ago (2014-10-21 11:03:52 UTC) #3
tkent
https://codereview.chromium.org/660783002/diff/80001/LayoutTests/fast/forms/reportValidity-001.html File LayoutTests/fast/forms/reportValidity-001.html (right): https://codereview.chromium.org/660783002/diff/80001/LayoutTests/fast/forms/reportValidity-001.html#newcode1 LayoutTests/fast/forms/reportValidity-001.html:1: <!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN"> The test name should ...
6 years, 2 months ago (2014-10-22 01:14:15 UTC) #4
tkent
On 2014/10/21 08:20:15, keishi wrote: > I think we want test if the validation message ...
6 years, 2 months ago (2014-10-22 01:15:56 UTC) #5
Bartek Nowierski
https://codereview.chromium.org/660783002/diff/80001/LayoutTests/fast/forms/reportValidity-001.html File LayoutTests/fast/forms/reportValidity-001.html (right): https://codereview.chromium.org/660783002/diff/80001/LayoutTests/fast/forms/reportValidity-001.html#newcode1 LayoutTests/fast/forms/reportValidity-001.html:1: <!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN"> On 2014/10/22 01:14:15, tkent ...
6 years, 2 months ago (2014-10-22 04:56:43 UTC) #6
tkent
lgtm https://codereview.chromium.org/660783002/diff/100001/Source/core/html/HTMLFormControlElement.cpp File Source/core/html/HTMLFormControlElement.cpp (right): https://codereview.chromium.org/660783002/diff/100001/Source/core/html/HTMLFormControlElement.cpp#newcode515 Source/core/html/HTMLFormControlElement.cpp:515: RefPtrWillBeRawPtr<HTMLFormControlElement> protector(this); Ah, I found |unhandledInvalidControls[0] kept a ...
6 years, 2 months ago (2014-10-22 05:41:37 UTC) #7
Bartek Nowierski
https://codereview.chromium.org/660783002/diff/100001/Source/core/html/HTMLFormControlElement.cpp File Source/core/html/HTMLFormControlElement.cpp (right): https://codereview.chromium.org/660783002/diff/100001/Source/core/html/HTMLFormControlElement.cpp#newcode515 Source/core/html/HTMLFormControlElement.cpp:515: RefPtrWillBeRawPtr<HTMLFormControlElement> protector(this); On 2014/10/22 05:41:37, tkent wrote: > Ah, ...
6 years, 2 months ago (2014-10-22 06:17:08 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/660783002/120001
6 years, 2 months ago (2014-10-22 06:24:45 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/32984)
6 years, 2 months ago (2014-10-22 08:59:04 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/660783002/120001
6 years, 2 months ago (2014-10-22 08:59:47 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/33029)
6 years, 2 months ago (2014-10-22 12:09:27 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/660783002/120001
6 years, 2 months ago (2014-10-22 12:21:17 UTC) #18
commit-bot: I haz the power
6 years, 2 months ago (2014-10-22 12:54:18 UTC) #19
Message was sent while issue was closed. 
Committed patchset #7 (id:120001) as 184177

Powered by Google App Engine
This is Rietveld 408576698