Implement reportValidity()

Source/core/html/HTMLFormControlElement.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  * Copyright (C) 2004, 2005, 2006, 2007 Apple Inc. All rights reserved.
  *           (C) 2006 Alexey Proskuryakov (ap@nypop.com)
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
@@ skipping 468 matching lines @@
 
 ValidationMessageClient* HTMLFormControlElement::validationMessageClient() const
 {
     Page* page = document().page();
     if (!page)
         return 0;
 
     return &page->validationMessageClient();
 }
 
-bool HTMLFormControlElement::checkValidity(WillBeHeapVector<RefPtrWillBeMember<FormAssociatedElement> >* unhandledInvalidControls, CheckValidityEventBehavior eventBehavior)
+bool HTMLFormControlElement::checkValidity(WillBeHeapVector<RefPtrWillBeMember<HTMLFormControlElement> >* unhandledInvalidControls, CheckValidityEventBehavior eventBehavior)
 {
     if (!willValidate() || isValidElement())
         return true;
     if (eventBehavior != CheckValidityDispatchInvalidEvent)
         return false;
     // An event handler can deref this object.
     RefPtrWillBeRawPtr<HTMLFormControlElement> protector(this);
     RefPtrWillBeRawPtr<Document> originalDocument(document());
     bool needsDefaultAction = dispatchEvent(Event::createCancelable(EventTypeNames::invalid));
     if (needsDefaultAction && unhandledInvalidControls && inDocument() && originalDocument == document())
         unhandledInvalidControls->append(this);
     return false;
 }
 
+void HTMLFormControlElement::showValidationMessage()
+{
+    scrollIntoViewIfNeeded(false);
+    RefPtrWillBeRawPtr<HTMLFormControlElement> protector(this);
+    focus();
+    updateVisibleValidationMessage();
+}
+
+bool HTMLFormControlElement::reportValidity()
+{
+    WillBeHeapVector<RefPtrWillBeMember<HTMLFormControlElement> > unhandledInvalidControls;
+    RefPtrWillBeRawPtr<HTMLFormControlElement> protector(this);

[tkent, 2014/10/22 05:41:37]

Ah, I found |unhandledInvalidControls[0] kept a reference count for |this|.  So,
|protector| is unnecessary.
HTMLFormElement::validateInteractively() is safe because of the same way.

[Bartek Nowierski, 2014/10/22 06:17:08]

Done.

+    bool isValid = checkValidity(&unhandledInvalidControls, CheckValidityDispatchInvalidEvent);
+    if (isValid || unhandledInvalidControls.isEmpty())
+        return isValid;
+    ASSERT(unhandledInvalidControls.size() == 1);
+    ASSERT(unhandledInvalidControls[0].get() == this);
+    // Update layout now vefore calling isFocusable(), which has

[tkent, 2014/10/22 05:41:37]

vefore -> before

[Bartek Nowierski, 2014/10/22 06:17:08]

Done.

+    // !renderer()->needsLayout() assertion.
+    document().updateLayoutIgnorePendingStylesheets();
+    if (isFocusable()) {
+        showValidationMessage();
+        return false;
+    }
+    if (document().frame()) {
+        String message("An invalid form control with name='%name' is not focusable.");
+        message.replace("%name", name());
+        document().addConsoleMessage(ConsoleMessage::create(RenderingMessageSource, ErrorMessageLevel, message));
+    }
+    return false;
+}
+
 bool HTMLFormControlElement::matchesValidityPseudoClasses() const
 {
     return willValidate();
 }
 
 bool HTMLFormControlElement::isValidElement()
 {
     // If the following assertion fails, setNeedsValidityCheck() is not called
     // correctly when something which changes validity is updated.
     ASSERT(m_isValid == valid());
@@ skipping 60 matching lines @@
 
 void HTMLFormControlElement::setFocus(bool flag)
 {
     LabelableElement::setFocus(flag);
 
     if (!flag && wasChangedSinceLastFormControlChangeEvent())
         dispatchFormControlChangeEvent();
 }
 
 } // namespace blink