Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 660713002: Disable FormStructureBrowserTest.DataDrivenHeuristics00 on Windows as well. (Closed)

Created:
6 years, 2 months ago by jam
Modified:
6 years, 2 months ago
CC:
chromium-reviews, benquan, browser-components-watch_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/autofill/form_structure_browsertest.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
jam
6 years, 2 months ago (2014-10-16 04:49:51 UTC) #2
jam
6 years, 2 months ago (2014-10-16 04:49:53 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/6508eb5e532c1c3c1c7a94a942211c1ac3f746f9 Cr-Commit-Position: refs/heads/master@{#299844}
6 years, 2 months ago (2014-10-16 04:51:30 UTC) #4
jam
Committed patchset #1 (id:20001) manually as 6508eb5e532c1c3c1c7a94a942211c1ac3f746f9 (presubmit successful).
6 years, 2 months ago (2014-10-16 04:51:33 UTC) #5
Evan Stade
Hmmm, I wonder if this line has to do with the problem: @@@STEP_LOG_LINE@DataDrivenHeuristics00@[4584:2832:1015/191017:ERROR:singleton_hwnd.cc(43)] Cannot create ...
6 years, 2 months ago (2014-10-16 16:36:07 UTC) #6
jam
On 2014/10/16 16:36:07, Evan Stade wrote: > Hmmm, I wonder if this line has to ...
6 years, 2 months ago (2014-10-16 17:49:38 UTC) #7
Daniel Erat
6 years, 2 months ago (2014-10-17 21:54:50 UTC) #9
Message was sent while issue was closed.
i think that i've possibly been encountering a related problem on chrome os
while trying to switch from RenderTextPango to RenderTextHarfBuzz; see
http://crbug.com/423791.

RenderTextHarfBuzz was enabled for other platforms (including windows) recently
in https://codereview.chromium.org/630583002; i wonder if that was responsible
for the windows timeouts.

for chrome os, my best guess at the moment is that these tests are doing
something in the course of omnibox rendering many times that's slower in
RenderTextHarfBuzz than in RenderTextPango.

Powered by Google App Engine
This is Rietveld 408576698