Enable HarfBuzz by default everywhere except CrOS

Enable HarfBuzz by default everywhere except CrOS

BUG=321868
TBR=msw

Committed: https://crrev.com/4d71ef95bbf74fe61b18da22d361d8b5911a5994
Cr-Commit-Position: refs/heads/master@{#299767}

[ckocagil, 2014-10-04 20:20:19]

The CQ bit was checked by ckocagil@chromium.org

[commit-bot: I haz the power, 2014-10-04 20:20:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/630583002/1

[commit-bot: I haz the power, 2014-10-04 21:40:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-04 21:40:03]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[ckocagil, 2014-10-05 17:50:50]

The CQ bit was checked by ckocagil@chromium.org

[ckocagil, 2014-10-05 17:50:58]

The CQ bit was unchecked by ckocagil@chromium.org

[ckocagil, 2014-10-05 17:52:26]

The CQ bit was checked by ckocagil@chromium.org

[commit-bot: I haz the power, 2014-10-05 17:53:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/630583002/20001

[msw, 2014-10-05 17:58:21]

https://codereview.chromium.org/630583002/diff/20001/ui/gfx/render_text.cc
File ui/gfx/render_text.cc (right):

https://codereview.chromium.org/630583002/diff/20001/ui/gfx/render_text.cc#ne...
ui/gfx/render_text.cc:402: base::win::Version::VERSION_WIN8;
Are you sure the sizing problem only affects windows 8.1 and not 8? Add a
comment referencing the blocking bug.

https://codereview.chromium.org/630583002/diff/20001/ui/gfx/render_text.cc#ne...
ui/gfx/render_text.cc:404: bool default_is_harfbuzz = false;
What is the chrome os blocker(s)? Add a comment referencing the bug(s).

[ckocagil, 2014-10-05 17:58:52]

The CQ bit was unchecked by ckocagil@chromium.org

[ckocagil, 2014-10-15 19:50:10]

Patchset #3 (id:40001) has been deleted

[ckocagil, 2014-10-15 19:50:44]

https://codereview.chromium.org/630583002/diff/20001/ui/gfx/render_text.cc
File ui/gfx/render_text.cc (right):

https://codereview.chromium.org/630583002/diff/20001/ui/gfx/render_text.cc#ne...
ui/gfx/render_text.cc:402: base::win::Version::VERSION_WIN8;
On 2014/10/05 17:58:21, msw wrote:
> Are you sure the sizing problem only affects windows 8.1 and not 8? Add a
> comment referencing the blocking bug.

This should be fixed on both as of
https://crrev.com/ec562a798a1835e0383e83bae7dc71dffcfc5fb0

https://codereview.chromium.org/630583002/diff/20001/ui/gfx/render_text.cc#ne...
ui/gfx/render_text.cc:404: bool default_is_harfbuzz = false;
On 2014/10/05 17:58:21, msw wrote:
> What is the chrome os blocker(s)? Add a comment referencing the bug(s).

Done.

[msw, 2014-10-15 20:09:57]

msw@chromium.org changed reviewers:
+ derat@chromium.org

[msw, 2014-10-15 20:09:57]

lgtm, but coordinate with derat@ as per his similar CL.

https://codereview.chromium.org/630583002/diff/60001/ui/gfx/render_text.cc
File ui/gfx/render_text.cc (right):

https://codereview.chromium.org/630583002/diff/60001/ui/gfx/render_text.cc#ne...
ui/gfx/render_text.cc:398: const bool default_is_harfbuzz = false;
nit: these could just be return statements below the switch handling.

[ckocagil, 2014-10-15 20:17:30]

On 2014/10/15 20:09:57, msw wrote:
> lgtm, but coordinate with derat@ as per his similar CL.

I already did!

https://codereview.chromium.org/630583002/diff/60001/ui/gfx/render_text.cc
File ui/gfx/render_text.cc (right):

https://codereview.chromium.org/630583002/diff/60001/ui/gfx/render_text.cc#ne...
ui/gfx/render_text.cc:398: const bool default_is_harfbuzz = false;
On 2014/10/15 20:09:57, msw wrote:
> nit: these could just be return statements below the switch handling.

Done.

[ckocagil, 2014-10-15 20:29:04]

The CQ bit was checked by ckocagil@chromium.org

[commit-bot: I haz the power, 2014-10-15 20:29:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/630583002/80001

[commit-bot: I haz the power, 2014-10-15 21:20:45]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2014-10-15 21:21:53]

Patchset 4 (id:??) landed as
https://crrev.com/4d71ef95bbf74fe61b18da22d361d8b5911a5994
Cr-Commit-Position: refs/heads/master@{#299767}