Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(121)

Issue 660663002: Clear pending events upon main frame navigation (Closed)

Created:
5 years, 1 month ago by jdduke (slow)
Modified:
4 years, 9 months ago
Reviewers:
CC:
chromium-reviews, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, jam, penghuang+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, James Su, jdduke+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Clear pending events upon main frame navigation Prevent buffered input from reaching an undesirable target by resetting the InputRouter when the main frame navigates to a different page. BUG=418402

Patch Set 1 #

Patch Set 2 : Fix perf tests #

Patch Set 3 : Fix signed #

Patch Set 4 : Updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+178 lines, -146 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuHelper.java View 1 2 3 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/apps/web_view_browsertest.cc View 1 2 3 1 chunk +10 lines, -10 lines 0 comments Download
M content/browser/android/content_view_core_impl.h View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/android/content_view_core_impl.cc View 1 2 3 1 chunk +8 lines, -2 lines 0 comments Download
M content/browser/renderer_host/input/input_ack_handler.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/input/input_router.h View 1 2 3 2 chunks +6 lines, -4 lines 0 comments Download
M content/browser/renderer_host/input/input_router_client.h View 1 chunk +0 lines, -8 lines 0 comments Download
M content/browser/renderer_host/input/input_router_impl.h View 1 2 3 3 chunks +6 lines, -1 line 0 comments Download
M content/browser/renderer_host/input/input_router_impl.cc View 1 2 3 12 chunks +32 lines, -13 lines 0 comments Download
M content/browser/renderer_host/input/input_router_impl_perftest.cc View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/renderer_host/input/input_router_impl_unittest.cc View 1 2 3 7 chunks +10 lines, -8 lines 0 comments Download
M content/browser/renderer_host/input/mock_input_router_client.h View 1 2 3 4 chunks +0 lines, -5 lines 0 comments Download
M content/browser/renderer_host/input/mock_input_router_client.cc View 2 chunks +6 lines, -16 lines 0 comments Download
M content/browser/renderer_host/input/synthetic_gesture_target_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/input/touch_event_queue.h View 2 chunks +4 lines, -4 lines 0 comments Download
M content/browser/renderer_host/input/touch_event_queue.cc View 3 chunks +10 lines, -10 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.h View 1 2 3 5 chunks +12 lines, -11 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.cc View 1 2 3 7 chunks +18 lines, -18 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_unittest.cc View 1 2 3 3 chunks +1 line, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.h View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.cc View 1 2 3 3 chunks +11 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_base.h View 1 2 3 1 chunk +0 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_base.cc View 1 2 3 1 chunk +0 lines, -4 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java View 1 2 3 5 chunks +8 lines, -12 lines 0 comments Download
M content/public/test/test_renderer_host.h View 1 2 3 1 chunk +3 lines, -2 lines 0 comments Download
M content/public/test/test_renderer_host.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M ui/events/gesture_detection/filtered_gesture_provider.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M ui/events/gesture_detection/filtered_gesture_provider.cc View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M ui/events/gesture_detection/gesture_provider.h View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M ui/events/gesture_detection/gesture_provider.cc View 1 2 3 2 chunks +9 lines, -1 line 0 comments Download
M ui/events/gesture_detection/touch_disposition_gesture_filter.cc View 1 2 3 3 chunks +7 lines, -0 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698