Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(456)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 660653004: Move supplemental transform to rare data (Closed)

Created:
6 years, 2 months ago by rwlbuis
Modified:
6 years, 2 months ago
Reviewers:
pdr.
CC:
blink-reviews, krit, ed+blinkwatch_opera.com, f(malita), fs, gyuyoung.kim_webkit.org, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Move supplemental transform to rare data The AffineTransformation for animateMotion is pretty rare and just makes SVGGraphicsElement take up more memory, so move it to SVGElementRareData. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183854

Patch Set 1 #

Patch Set 2 : Fix build #

Total comments: 1

Patch Set 3 : Patch for landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -17 lines) Patch
M Source/core/svg/SVGAnimateMotionElement.cpp View 1 2 5 chunks +5 lines, -5 lines 0 comments Download
M Source/core/svg/SVGElement.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGElementRareData.h View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
M Source/core/svg/SVGElementRareData.cpp View 1 2 2 chunks +7 lines, -0 lines 0 comments Download
M Source/core/svg/SVGGraphicsElement.h View 1 2 2 chunks +1 line, -4 lines 0 comments Download
M Source/core/svg/SVGGraphicsElement.cpp View 1 2 2 chunks +6 lines, -6 lines 0 comments Download
M Source/core/svg/SVGTextElement.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
rwlbuis
PTAL
6 years, 2 months ago (2014-10-16 22:46:51 UTC) #2
pdr.
LGTM https://codereview.chromium.org/660653004/diff/20001/Source/core/svg/SVGElementRareData.h File Source/core/svg/SVGElementRareData.h (right): https://codereview.chromium.org/660653004/diff/20001/Source/core/svg/SVGElementRareData.h#newcode101 Source/core/svg/SVGElementRareData.h:101: OwnPtr<AffineTransform> m_supplementalTransform; Can we fold this comment into ...
6 years, 2 months ago (2014-10-16 22:50:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/660653004/20001
6 years, 2 months ago (2014-10-16 22:50:31 UTC) #5
pdr.
Oops, didn't mean to click CQ. Happy to see this land with or without my ...
6 years, 2 months ago (2014-10-16 22:52:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/660653004/40001
6 years, 2 months ago (2014-10-17 01:51:57 UTC) #9
commit-bot: I haz the power
6 years, 2 months ago (2014-10-17 04:07:51 UTC) #10
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as 183854

Powered by Google App Engine
This is Rietveld 408576698