chrome/browser/ui/extensions/extension_install_ui_default.cc - Issue 660643002: [Refactor] Move creating a browser if necessary to ExtensionInstallDialogView

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/extensions/extension_install_ui_default.cc

Issue 660643002: [Refactor] Move creating a browser if necessary to ExtensionInstallDialogView (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/cocoa/extensions/windowed_install_dialog_controller.mm ('K') | « chrome/browser/ui/extensions/extension_enable_flow.cc ('k') | chrome/browser/ui/views/extensions/extension_install_dialog_view.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/extensions/extension_install_ui_default.cc

diff --git a/chrome/browser/ui/extensions/extension_install_ui_default.cc b/chrome/browser/ui/extensions/extension_install_ui_default.cc

index dd8ca0a2a5d74221ff523234e8c5b994fd9763ad..d4d1b8d296efd66c1038e598b2f18ea74afd7327 100644

--- a/chrome/browser/ui/extensions/extension_install_ui_default.cc

+++ b/chrome/browser/ui/extensions/extension_install_ui_default.cc

@@ -189,10 +189,9 @@ ExtensionInstallPrompt* ExtensionInstallUI::CreateInstallPromptWithProfile(

return CreateInstallPromptWithBrowser(browser);

// No browser window is open yet. Create a free-standing dialog associated

// with |profile|.

- return new ExtensionInstallPrompt(profile, NULL, NULL);

+ return new ExtensionInstallPrompt(profile, NULL);

}

// ExtensionInstallUIDefault --------------------------------------------------

ExtensionInstallUIDefault::ExtensionInstallUIDefault(Profile* profile)