Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3717)

Unified Diff: chrome/browser/ui/extensions/extension_enable_flow.cc

Issue 660643002: [Refactor] Move creating a browser if necessary to ExtensionInstallDialogView (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/extensions/extension_enable_flow.cc
diff --git a/chrome/browser/ui/extensions/extension_enable_flow.cc b/chrome/browser/ui/extensions/extension_enable_flow.cc
index ebfbdb771dc65650625a82dc99bbb21972a85dac..8e305e7931f2e8d5f8ca71187691b3ccf6e5c91c 100644
--- a/chrome/browser/ui/extensions/extension_enable_flow.cc
+++ b/chrome/browser/ui/extensions/extension_enable_flow.cc
@@ -7,9 +7,7 @@
#include "chrome/browser/chrome_notification_types.h"
#include "chrome/browser/extensions/extension_service.h"
#include "chrome/browser/profiles/profile.h"
-#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/extensions/extension_enable_flow_delegate.h"
-#include "chrome/browser/ui/scoped_tabbed_browser_displayer.h"
#include "content/public/browser/notification_details.h"
#include "content/public/browser/notification_source.h"
#include "extensions/browser/extension_prefs.h"
@@ -108,7 +106,7 @@ void ExtensionEnableFlow::CreatePrompt() {
parent_window_ = window_getter_.Run();
prompt_.reset(parent_contents_ ?
new ExtensionInstallPrompt(parent_contents_) :
- new ExtensionInstallPrompt(profile_, parent_window_, this));
+ new ExtensionInstallPrompt(profile_, parent_window_));
}
void ExtensionEnableFlow::StartObserving() {
@@ -171,10 +169,3 @@ void ExtensionEnableFlow::InstallUIAbort(bool user_initiated) {
delegate_->ExtensionEnableFlowAborted(user_initiated);
// |delegate_| may delete us.
}
-
-content::WebContents* ExtensionEnableFlow::OpenURL(
- const content::OpenURLParams& params) {
- chrome::ScopedTabbedBrowserDisplayer displayer(
- profile_, chrome::GetActiveDesktop());
- return displayer.browser()->OpenURL(params);
-}

Powered by Google App Engine
This is Rietveld 408576698