chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller.mm - Issue 660643002: [Refactor] Move creating a browser if necessary to ExtensionInstallDialogView

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller.mm

Issue 660643002: [Refactor] Move creating a browser if necessary to ExtensionInstallDialogView (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/webstore_install_with_prompt.cc ('k') | chrome/browser/ui/cocoa/extensions/extension_install_view_controller.h » ('j') | chrome/browser/ui/cocoa/extensions/windowed_install_dialog_controller.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller.mm

diff --git a/chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller.mm b/chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller.mm

index d3f05ea69643ce1db806d3407722089379000da0..f8e45030fd08ce1b1c64d1a2ef5e9cbfbebea334 100644

--- a/chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller.mm

+++ b/chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller.mm

@@ -43,9 +43,10 @@ ExtensionInstallDialogController::ExtensionInstallDialogController(

scoped_refptr<ExtensionInstallPrompt::Prompt> prompt)

: delegate_(delegate) {

view_controller_.reset([[ExtensionInstallViewController alloc]

- initWithNavigator:show_params.navigator

- delegate:this

- prompt:prompt]);

+ initWithProfile:show_params.profile

+ navigator:show_params.parent_web_contents

+ delegate:this

+ prompt:prompt]);

base::scoped_nsobject<NSWindow> window([[ConstrainedWindowCustomWindow alloc]

initWithContentRect:[[view_controller_ view] bounds]]);