Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1377)

Unified Diff: chrome/browser/extensions/webstore_install_with_prompt.cc

Issue 660643002: [Refactor] Move creating a browser if necessary to ExtensionInstallDialogView (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/webstore_install_with_prompt.cc
diff --git a/chrome/browser/extensions/webstore_install_with_prompt.cc b/chrome/browser/extensions/webstore_install_with_prompt.cc
index 4e69d8d08a73e8585d81cd7af3742d6f22167af4..f66acc1a2e5ca6bc23fda115f1fd890d13a9d11b 100644
--- a/chrome/browser/extensions/webstore_install_with_prompt.cc
+++ b/chrome/browser/extensions/webstore_install_with_prompt.cc
@@ -6,8 +6,6 @@
#include "chrome/browser/extensions/webstore_installer.h"
#include "chrome/browser/profiles/profile.h"
-#include "chrome/browser/ui/browser.h"
-#include "chrome/browser/ui/scoped_tabbed_browser_displayer.h"
#include "content/public/browser/web_contents.h"
using content::WebContents;
@@ -62,8 +60,7 @@ scoped_ptr<ExtensionInstallPrompt>
WebstoreInstallWithPrompt::CreateInstallUI() {
// Create an ExtensionInstallPrompt. If the parent window is NULL, the dialog
// will be placed in the middle of the screen.
- return make_scoped_ptr(
- new ExtensionInstallPrompt(profile(), parent_window_, this));
+ return make_scoped_ptr(new ExtensionInstallPrompt(profile(), parent_window_));
}
bool WebstoreInstallWithPrompt::ShouldShowPostInstallUI() const {
@@ -94,11 +91,4 @@ bool WebstoreInstallWithPrompt::CheckRequestorPermitted(
return true;
}
-content::WebContents* WebstoreInstallWithPrompt::OpenURL(
- const content::OpenURLParams& params) {
- chrome::ScopedTabbedBrowserDisplayer displayer(profile(),
- chrome::GetActiveDesktop());
- return displayer.browser()->OpenURL(params);
-}
-
} // namespace extensions

Powered by Google App Engine
This is Rietveld 408576698