Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(724)

Unified Diff: chrome/browser/extensions/webstore_install_with_prompt.h

Issue 660643002: [Refactor] Move creating a browser if necessary to ExtensionInstallDialogView (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/webstore_install_with_prompt.h
diff --git a/chrome/browser/extensions/webstore_install_with_prompt.h b/chrome/browser/extensions/webstore_install_with_prompt.h
index 91ec9be0f732035f1910496a9c19a9d859b5ec63..d7e876173d18117d1c2028a2568e3ad33353472b 100644
--- a/chrome/browser/extensions/webstore_install_with_prompt.h
+++ b/chrome/browser/extensions/webstore_install_with_prompt.h
@@ -8,7 +8,6 @@
#include "base/basictypes.h"
#include "base/memory/scoped_ptr.h"
#include "chrome/browser/extensions/webstore_standalone_installer.h"
-#include "content/public/browser/page_navigator.h"
#include "ui/gfx/native_widget_types.h"
#include "url/gurl.h"
@@ -28,8 +27,7 @@ namespace extensions {
// Clients of this class must be trusted, as verification of the requestor is
// skipped. This class stubs out many WebstoreStandaloneInstaller abstract
// methods and can be used as a base class.
-class WebstoreInstallWithPrompt : public WebstoreStandaloneInstaller,
- public content::PageNavigator {
+class WebstoreInstallWithPrompt : public WebstoreStandaloneInstaller {
public:
// Use this constructor when there is no parent window. The install dialog
// will be centered on the screen.
@@ -66,10 +64,6 @@ class WebstoreInstallWithPrompt : public WebstoreStandaloneInstaller,
const base::DictionaryValue& webstore_data,
std::string* error) const override;
- // content::PageNavigator overrides:
- virtual content::WebContents* OpenURL(
- const content::OpenURLParams& params) override;
-
private:
bool show_post_install_ui_;

Powered by Google App Engine
This is Rietveld 408576698