options: fix "Import" button for idle options pages.

chrome/browser/resources/options/import_data_overlay.js

Index: chrome/browser/resources/options/import_data_overlay.js
diff --git a/chrome/browser/resources/options/import_data_overlay.js b/chrome/browser/resources/options/import_data_overlay.js
index 600c9fa89b86771285d54a8b8d55779bd1d8caa0..b4f659820913855fb4c6d9f1ac53c16ad215b58f 100644
--- a/chrome/browser/resources/options/import_data_overlay.js
+++ b/chrome/browser/resources/options/import_data_overlay.js
@@ -32,8 +32,11 @@ cr.define('options', function() {
       var checkboxes =
           document.querySelectorAll('#import-checkboxes input[type=checkbox]');
       for (var i = 0; i < checkboxes.length; i++) {
-        checkboxes[i].onchange = function() {
+        checkboxes[i].onchange = this.validateCommitButton_.bind(this);

[Evan Stade, 2014/10/15 21:51:50]

this is still necessary even with the new customPrefChangeHandler? That's odd.

instead of onchange =, how about addEventListener?

[Dan Beam, 2014/10/16 01:32:56]

Nope. Good call (bummer I didn't see it).
Code dead.

+        checkboxes[i].customPrefChangeHandler = function(e) {
+          options.PrefCheckbox.prototype.defaultPrefChangeHandler.call(this, e);
           self.validateCommitButton_();
+          return true;
         };
       }