options: fix "Import" button for idle options pages.

options: fix "Import" button for idle options pages.

R=estade@chromium.org
BUG=275265
TEST=open chrome://settings/importData in 2 windows, uncheck all checkboxes => "Import" disabled both places

Committed: https://crrev.com/193a75a3a2720f7d05e4aed07afbc0167d547fcc
Cr-Commit-Position: refs/heads/master@{#300152}

[Dan Beam, 2014-10-15 19:24:30]

Patchset #1 (id:1) has been deleted

[Dan Beam, 2014-10-15 19:28:50]

Patchset #1 (id:20001) has been deleted

[Evan Stade, 2014-10-15 21:51:50]

https://codereview.chromium.org/660623002/diff/40001/chrome/browser/resources...
File chrome/browser/resources/options/import_data_overlay.js (right):

https://codereview.chromium.org/660623002/diff/40001/chrome/browser/resources...
chrome/browser/resources/options/import_data_overlay.js:35:
checkboxes[i].onchange = this.validateCommitButton_.bind(this);
this is still necessary even with the new customPrefChangeHandler? That's odd.

instead of onchange =, how about addEventListener?

[Dan Beam, 2014-10-16 01:32:56]

https://codereview.chromium.org/660623002/diff/40001/chrome/browser/resources...
File chrome/browser/resources/options/import_data_overlay.js (right):

https://codereview.chromium.org/660623002/diff/40001/chrome/browser/resources...
chrome/browser/resources/options/import_data_overlay.js:35:
checkboxes[i].onchange = this.validateCommitButton_.bind(this);
On 2014/10/15 21:51:50, Evan Stade wrote:
> this is still necessary even with the new customPrefChangeHandler? That's odd.

Nope. Good call (bummer I didn't see it).

> 
> instead of onchange =, how about addEventListener?

Code dead.

[Evan Stade, 2014-10-16 01:33:35]

lgtm

[Dan Beam, 2014-10-17 19:08:35]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2014-10-17 19:09:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/660623002/60001

[commit-bot: I haz the power, 2014-10-17 20:09:56]

Committed patchset #2 (id:60001)

[commit-bot: I haz the power, 2014-10-17 20:11:08]

Patchset 2 (id:??) landed as
https://crrev.com/193a75a3a2720f7d05e4aed07afbc0167d547fcc
Cr-Commit-Position: refs/heads/master@{#300152}