Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(11)

Issue 6606024: Eliminate ConenctionType, etc from chromeos_network.h (Closed)

Created:
8 years, 5 months ago by stevenjb
Modified:
8 years, 3 months ago
CC:
chromium-os-reviews_chromium.org, DaveMoore, Eric Shienbrood
Visibility:
Public.

Description

Eliminate ConenctionType, etc from chromeos_network.h Move them into network_library.h in Chrome for easier maintenance. Also convert type dependent API functions to async and do some cleanup. BUG=chromium-os:12681 TEST=Test network UI code (see issue) Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=fa0877f

Patch Set 1 #

Total comments: 4

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+399 lines, -328 lines) Patch
M chromeos_cros_api.h View 1 chunk +5 lines, -1 line 0 comments Download
M chromeos_network.h View 4 chunks +13 lines, -104 lines 0 comments Download
M chromeos_network.cc View 40 chunks +183 lines, -223 lines 0 comments Download
M chromeos_network_deprecated.h View 3 chunks +102 lines, -0 lines 0 comments Download
M chromeos_network_deprecated.cc View 5 chunks +89 lines, -0 lines 0 comments Download
M load.cc View 1 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
stevenjb
Round 2. Much smaller than Round 1. Chrome CL to follow shortly. http://codereview.chromium.org/6606024/diff/1/chromeos_network.cc File chromeos_network.cc ...
8 years, 5 months ago (2011-03-02 23:35:57 UTC) #1
Charlie Lee
LGTM
8 years, 5 months ago (2011-03-03 00:09:52 UTC) #2
Nathan Williams
8 years, 5 months ago (2011-03-03 22:28:42 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698