Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Issue 6606002: Merge revision 6500-6600 from bleeding_edge to the isolates branch. (Closed)

Created:
9 years, 9 months ago by Mads Ager (chromium)
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Merge revision 6500-6600 from bleeding_edge to the isolates branch.

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3033 lines, -1188 lines) Patch
M .gitignore View 1 chunk +2 lines, -0 lines 0 comments Download
M AUTHORS View 1 chunk +1 line, -0 lines 0 comments Download
M ChangeLog View 1 chunk +27 lines, -0 lines 0 comments Download
A LICENSE.strongtalk View 1 1 chunk +29 lines, -0 lines 0 comments Download
A LICENSE.v8 View 1 1 chunk +26 lines, -0 lines 0 comments Download
A LICENSE.valgrind View 1 1 chunk +45 lines, -0 lines 0 comments Download
M MERGE View 1 chunk +1 line, -1 line 0 comments Download
M include/v8.h View 2 chunks +17 lines, -2 lines 0 comments Download
M src/accessors.cc View 4 chunks +30 lines, -38 lines 0 comments Download
M src/api.cc View 7 chunks +20 lines, -16 lines 0 comments Download
M src/arm/assembler-arm.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/arm/assembler-arm.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M src/arm/code-stubs-arm.h View 1 chunk +5 lines, -2 lines 0 comments Download
M src/arm/code-stubs-arm.cc View 14 chunks +222 lines, -149 lines 0 comments Download
M src/arm/codegen-arm.cc View 2 chunks +8 lines, -2 lines 0 comments Download
M src/arm/deoptimizer-arm.cc View 5 chunks +21 lines, -12 lines 0 comments Download
M src/arm/disasm-arm.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/arm/full-codegen-arm.cc View 3 chunks +9 lines, -5 lines 0 comments Download
M src/arm/jump-target-arm.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M src/arm/lithium-arm.h View 3 chunks +5 lines, -4 lines 0 comments Download
M src/arm/lithium-arm.cc View 5 chunks +21 lines, -7 lines 0 comments Download
M src/arm/lithium-codegen-arm.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 16 chunks +123 lines, -100 lines 0 comments Download
M src/arm/macro-assembler-arm.h View 2 chunks +14 lines, -0 lines 0 comments Download
M src/arm/macro-assembler-arm.cc View 4 chunks +30 lines, -1 line 0 comments Download
M src/arm/simulator-arm.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/arm/stub-cache-arm.cc View 1 chunk +11 lines, -2 lines 0 comments Download
M src/arm/virtual-frame-arm.cc View 2 chunks +3 lines, -1 line 0 comments Download
M src/array.js View 2 chunks +8 lines, -6 lines 0 comments Download
M src/assembler.h View 2 chunks +1 line, -2 lines 0 comments Download
M src/assembler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/ast.h View 3 chunks +1 line, -6 lines 0 comments Download
M src/ast.cc View 3 chunks +25 lines, -26 lines 1 comment Download
M src/bootstrapper.cc View 2 chunks +1 line, -3 lines 0 comments Download
M src/builtins.cc View 1 chunk +23 lines, -19 lines 0 comments Download
M src/code-stubs.h View 2 chunks +14 lines, -0 lines 0 comments Download
M src/date.js View 2 chunks +2 lines, -2 lines 0 comments Download
M src/deoptimizer.h View 2 chunks +16 lines, -1 line 0 comments Download
M src/deoptimizer.cc View 1 chunk +38 lines, -0 lines 0 comments Download
M src/extensions/experimental/i18n-extension.cc View 2 chunks +12 lines, -11 lines 0 comments Download
M src/factory.h View 1 chunk +9 lines, -0 lines 0 comments Download
M src/factory.cc View 1 chunk +19 lines, -0 lines 0 comments Download
M src/frames.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/gdb-jit.h View 2 chunks +3 lines, -1 line 0 comments Download
M src/gdb-jit.cc View 13 chunks +348 lines, -26 lines 0 comments Download
M src/hashmap.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/heap.h View 2 chunks +14 lines, -0 lines 0 comments Download
M src/heap.cc View 2 chunks +32 lines, -0 lines 0 comments Download
M src/heap-profiler.cc View 2 chunks +2 lines, -1 line 0 comments Download
M src/hydrogen.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/hydrogen.cc View 8 chunks +33 lines, -15 lines 0 comments Download
M src/hydrogen-instructions.h View 9 chunks +32 lines, -9 lines 0 comments Download
M src/hydrogen-instructions.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 3 chunks +30 lines, -4 lines 0 comments Download
M src/ia32/codegen-ia32.cc View 2 chunks +8 lines, -4 lines 0 comments Download
M src/ia32/deoptimizer-ia32.cc View 5 chunks +102 lines, -73 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 8 chunks +59 lines, -47 lines 0 comments Download
M src/ia32/lithium-ia32.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 4 chunks +15 lines, -6 lines 0 comments Download
M src/ia32/stub-cache-ia32.cc View 1 chunk +14 lines, -4 lines 0 comments Download
M src/isolate.h View 1 chunk +1 line, -1 line 0 comments Download
M src/json.js View 3 chunks +3 lines, -3 lines 0 comments Download
M src/lithium-allocator.cc View 3 chunks +7 lines, -4 lines 0 comments Download
M src/messages.h View 1 chunk +6 lines, -5 lines 0 comments Download
M src/messages.cc View 1 chunk +25 lines, -48 lines 0 comments Download
M src/messages.js View 13 chunks +131 lines, -152 lines 0 comments Download
M src/mirror-debugger.js View 21 chunks +22 lines, -22 lines 0 comments Download
M src/objects.h View 5 chunks +69 lines, -1 line 0 comments Download
M src/objects.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M src/objects-debug.cc View 2 chunks +16 lines, -0 lines 0 comments Download
M src/objects-inl.h View 10 chunks +38 lines, -14 lines 0 comments Download
M src/objects-printer.cc View 3 chunks +22 lines, -0 lines 0 comments Download
M src/objects-visiting.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/parser.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/parser.cc View 7 chunks +39 lines, -5 lines 0 comments Download
M src/regexp.js View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime.h View 1 chunk +7 lines, -0 lines 0 comments Download
M src/runtime.cc View 3 chunks +148 lines, -23 lines 0 comments Download
M src/safepoint-table.h View 3 chunks +12 lines, -22 lines 0 comments Download
M src/safepoint-table.cc View 4 chunks +17 lines, -37 lines 0 comments Download
M src/scanner-base.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/scanner-base.cc View 2 chunks +8 lines, -2 lines 0 comments Download
M src/top.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M src/type-info.h View 2 chunks +2 lines, -8 lines 0 comments Download
M src/type-info.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/utils.h View 1 chunk +22 lines, -10 lines 0 comments Download
M src/variables.h View 1 chunk +7 lines, -5 lines 0 comments Download
M src/variables.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/version.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 chunk +22 lines, -0 lines 0 comments Download
M src/x64/codegen-x64.cc View 2 chunks +8 lines, -4 lines 0 comments Download
M src/x64/deoptimizer-x64.cc View 4 chunks +18 lines, -11 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M src/x64/lithium-codegen-x64.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 12 chunks +155 lines, -39 lines 0 comments Download
M src/x64/lithium-x64.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/x64/lithium-x64.cc View 12 chunks +63 lines, -30 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 1 chunk +12 lines, -4 lines 0 comments Download
M src/x64/stub-cache-x64.cc View 1 chunk +10 lines, -2 lines 0 comments Download
M test/cctest/cctest.status View 2 chunks +0 lines, -6 lines 0 comments Download
M test/cctest/test-api.cc View 6 chunks +128 lines, -20 lines 0 comments Download
M test/cctest/test-assembler-arm.cc View 4 chunks +15 lines, -0 lines 0 comments Download
M test/cctest/test-disasm-arm.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M test/cctest/test-log.cc View 1 chunk +15 lines, -0 lines 0 comments Download
M test/mjsunit/array-splice.js View 1 chunk +14 lines, -0 lines 0 comments Download
M test/mjsunit/compiler/literals.js View 1 chunk +3 lines, -0 lines 0 comments Download
A test/mjsunit/compiler/regress-1085.js View 1 1 chunk +35 lines, -0 lines 0 comments Download
M test/mjsunit/debug-backtrace-text.js View 1 chunk +3 lines, -3 lines 0 comments Download
M test/mjsunit/delete-global-properties.js View 2 chunks +14 lines, -3 lines 0 comments Download
M test/mjsunit/math-pow.js View 4 chunks +29 lines, -16 lines 0 comments Download
M test/mjsunit/mirror-error.js View 1 chunk +1 line, -1 line 0 comments Download
A test/mjsunit/regress/regress-1079.js View 1 1 chunk +45 lines, -0 lines 0 comments Download
A test/mjsunit/regress/regress-3408144.js View 1 1 chunk +37 lines, -0 lines 0 comments Download
A test/mjsunit/regress/regress-71647.js View 1 1 chunk +34 lines, -0 lines 0 comments Download
M test/mjsunit/strict-mode.js View 5 chunks +138 lines, -45 lines 0 comments Download
M tools/v8.xcodeproj/project.pbxproj View 4 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Mads Ager (chromium)
9 years, 9 months ago (2011-03-02 16:16:46 UTC) #1
Vitaly Repeshko
LGTM, thanks! http://codereview.chromium.org/6606002/diff/1/src/runtime.cc File src/runtime.cc (right): http://codereview.chromium.org/6606002/diff/1/src/runtime.cc#newcode11317 src/runtime.cc:11317: HandleScope scope; It's not performance critical, but ...
9 years, 9 months ago (2011-03-02 16:41:09 UTC) #2
Mads Ager (chromium)
9 years, 9 months ago (2011-03-02 16:45:50 UTC) #3
Turns out Dmitry has a change with 100 additional revisions. I'll abandon this
one and let Dmitry land his change. :)

Powered by Google App Engine
This is Rietveld 408576698