Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(628)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 660573003: Properly parse compiler errors for fiddles and mark them in the editor. (Closed)

Created:
6 years, 2 months ago by humper
Modified:
6 years, 2 months ago
Reviewers:
tfarina, jcgregorio
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Properly parse compiler errors for fiddles and mark them in the editor. You can also click on the errors in the parsed output to jump directly to the offending location in the editor. BUG=skia: NOTRY=true Committed: https://skia.googlesource.com/skia/+/ae8ab6296699ad74fead36c5e5cedf54cdf37e62

Patch Set 1 #

Total comments: 4

Patch Set 2 : Move regex compilation to the top of the file to only compile once. #

Patch Set 3 : log --> glog #

Unified diffs Side-by-side diffs Delta from patch set Stats (+133 lines, -26 lines) Patch
M experimental/webtry/res/js/webtry.js View 5 chunks +56 lines, -14 lines 0 comments Download
M experimental/webtry/res/webtry/css/webtry.css View 1 chunk +1 line, -1 line 0 comments Download
M experimental/webtry/res/webtry/sass/webtry.scss View 1 chunk +9 lines, -1 line 0 comments Download
M experimental/webtry/templates/content.html View 1 chunk +5 lines, -5 lines 0 comments Download
M experimental/webtry/webtry.go View 1 2 6 chunks +62 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
humper
ptal
6 years, 2 months ago (2014-10-15 19:02:10 UTC) #2
jcgregorio
https://codereview.chromium.org/660573003/diff/1/experimental/webtry/webtry.go File experimental/webtry/webtry.go (right): https://codereview.chromium.org/660573003/diff/1/experimental/webtry/webtry.go#newcode897 experimental/webtry/webtry.go:897: errorRE := regexp.MustCompile(fmt.Sprintf("^.*%s.cpp:(\\d+):(\\d+):\\s*(.*)", hash)) Move to top of file ...
6 years, 2 months ago (2014-10-15 19:59:50 UTC) #3
tfarina
https://codereview.chromium.org/660573003/diff/1/experimental/webtry/webtry.go File experimental/webtry/webtry.go (right): https://codereview.chromium.org/660573003/diff/1/experimental/webtry/webtry.go#newcode903 experimental/webtry/webtry.go:903: log.Printf("ERROR: Couldn't parse line number from %s\n", match[1]) On ...
6 years, 2 months ago (2014-10-15 20:05:21 UTC) #4
humper
https://codereview.chromium.org/660573003/diff/1/experimental/webtry/webtry.go File experimental/webtry/webtry.go (right): https://codereview.chromium.org/660573003/diff/1/experimental/webtry/webtry.go#newcode897 experimental/webtry/webtry.go:897: errorRE := regexp.MustCompile(fmt.Sprintf("^.*%s.cpp:(\\d+):(\\d+):\\s*(.*)", hash)) On 2014/10/15 19:59:50, jcgregorio wrote: ...
6 years, 2 months ago (2014-10-15 21:04:00 UTC) #5
jcgregorio
On 2014/10/15 21:04:00, humper wrote: > https://codereview.chromium.org/660573003/diff/1/experimental/webtry/webtry.go > File experimental/webtry/webtry.go (right): > > https://codereview.chromium.org/660573003/diff/1/experimental/webtry/webtry.go#newcode897 > ...
6 years, 2 months ago (2014-10-16 12:59:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/660573003/40001
6 years, 2 months ago (2014-10-16 14:13:58 UTC) #10
commit-bot: I haz the power
6 years, 2 months ago (2014-10-16 16:18:20 UTC) #11
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as ae8ab6296699ad74fead36c5e5cedf54cdf37e62

Powered by Google App Engine
This is Rietveld 408576698