Properly parse compiler errors for fiddles and mark them in the editor.

experimental/webtry/webtry.go

 package main
 
 import (
         "bytes"
         "crypto/md5"
         "database/sql"
         "encoding/base64"
         "encoding/binary"
         "encoding/json"
         "flag"
         "fmt"
         htemplate "html/template"
         "image"
         _ "image/gif"
         _ "image/jpeg"
         "image/png"
         "io/ioutil"
         "log"
         "math/rand"
         "net"
         "net/http"
         "os"
         "os/exec"
         "path/filepath"
         "regexp"
+        "strconv"
         "strings"
         "text/template"
         "time"
 )
 
 import (
         "github.com/fiorix/go-web/autogzip"
         _ "github.com/go-sql-driver/mysql"
         _ "github.com/mattn/go-sqlite3"
         "github.com/rcrowley/go-metrics"
@@ skipping 361 matching lines @@
         return hash, err
 }
 
 // expandGyp produces the GYP file needed to build the code
 func expandGyp(hash string) error {
         return writeTemplate(fmt.Sprintf("../../../cache/%s.gyp", hash), gypTemplate, struct{ Hash string }{hash})
 }
 
 // response is serialized to JSON as a response to POSTs.
 type response struct {
-        Message string `json:"message"`
-        StdOut  string `json:"stdout"`
-        Img     string `json:"img"`
-        Hash    string `json:"hash"`
+        Message       string         `json:"message"`
+        CompileErrors []compileError `json:"compileErrors"`
+        Img           string         `json:"img"`
+        Hash          string         `json:"hash"`
 }
 
 // doCmd executes the given command line string; the command being
 // run is expected to not care what its current working directory is.
 // Returns the stdout and stderr.
 func doCmd(commandLine string) (string, error) {
         log.Printf("Command: %q\n", commandLine)
         programAndArgs := strings.SplitN(commandLine, " ", 2)
         program := programAndArgs[0]
         args := []string{}
@@ skipping 18 matching lines @@
 }
 
 // reportTryError formats an HTTP error response in JSON and also logs the detailed error message.
 func reportTryError(w http.ResponseWriter, r *http.Request, err error, message, hash string) {
         m := response{
                 Message: message,
                 Hash:    hash,
         }
         log.Printf("Error: %s\n%s", message, err.Error())
         resp, err := json.Marshal(m)
+
         if err != nil {
                 http.Error(w, "Failed to serialize a response", 500)
                 return
+        }
+        w.Header().Set("Content-Type", "text/plain")
+        w.Write(resp)
+}
+
+func reportCompileError(w http.ResponseWriter, r *http.Request, compileErrors []compileError, hash string) {
+        m := response{
+                CompileErrors: compileErrors,
+                Hash:          hash,
+        }
+
+        resp, err := json.Marshal(m)
+
+        if err != nil {
+                http.Error(w, "Failed to serialize a response", 500)
+                return
         }
         w.Header().Set("Content-Type", "text/plain")
         w.Write(resp)
 }
 
 func writeToDatabase(hash string, code string, workspaceName string, source int, width, height int, gpu bool) {
         if db == nil {
                 return
         }
         if _, err := db.Exec("INSERT INTO webtry (code, hash, width, height, gpu, source_image_id) VALUES(?, ?, ?, ?, ?, ?)", code, hash, width, height, gpu, source); err != nil {
@@ skipping 323 matching lines @@
         w.Header().Set("Content-Type", "application/json")
         w.Write(resp)
 }
 
 func cleanCompileOutput(s, hash string) string {
         old := "../../../cache/src/" + hash + ".cpp:"
         log.Printf("INFO: replacing %q\n", old)
         return strings.Replace(s, old, "usercode.cpp:", -1)
 }
 
+type compileError struct {
+        Line   int    `json:"line"`
+        Column int    `json:"column"`
+        Error  string `json:"error"`
+}
+
 // mainHandler handles the GET and POST of the main page.
 func mainHandler(w http.ResponseWriter, r *http.Request) {
         log.Printf("Main Handler: %q\n", r.URL.Path)
         requestsCounter.Inc(1)
         if r.Method == "GET" {
                 code := DEFAULT_SAMPLE
                 source := 0
                 width := 256
                 height := 256
                 gpu := false
@@ skipping 55 matching lines @@
                         cmd += " --gpu"
                 }
                 if *useChroot {
                         cmd = "schroot -c webtry --directory=/ -- /skia_build/skia/experimental/webtry/" + cmd
                 }
                 if request.Source > 0 {
                         cmd += fmt.Sprintf(" --source image-%d.png", request.Source)
                 }
 
                 message, err := doCmd(cmd)
+
+                outputLines := strings.Split(message, "\n")
+                errorLines := []compileError{}
+                errorRE := regexp.MustCompile(fmt.Sprintf("^.*%s.cpp:(\\d+):(\\d+):\\s*(.*)", hash))

[jcgregorio, 2014/10/15 19:59:50]

Move to top of file so it's only compiled once.

[humper, 2014/10/15 21:03:59]

Done.

+                for _, line := range outputLines {
+                        match := errorRE.FindStringSubmatch(line)
+                        if len(match) > 0 {
+                                lineNumber, parseError := strconv.Atoi(match[1])
+                                if parseError != nil {
+                                        log.Printf("ERROR: Couldn't parse line number from %s\n", match[1])

[jcgregorio, 2014/10/15 19:59:50]

Add a TODO to switch from log to glog (http://godoc.org/github.com/golang/glog).

[tfarina, 2014/10/15 20:05:21]

I will do that. I have a bug filed for that:
https://code.google.com/p/skia/issues/detail?id=2980

+                                        continue
+                                }
+                                columnNumber, parseError := strconv.Atoi(match[2])
+                                if parseError != nil {
+                                        log.Printf("ERROR: Couldn't parse column number from %s\n", match[2])
+                                        continue
+                                }
+                                errorLines = append(errorLines,
+                                        compileError{
+                                                Line:   lineNumber,
+                                                Column: columnNumber,
+                                                Error:  match[3],
+                                        })
+                        }
+                }
+
                 if err != nil {
-                        reportTryError(w, r, err, "Failed to run the code:\n"+message, hash)
+                        if len(errorLines) > 0 {
+                                reportCompileError(w, r, errorLines, hash)
+                        } else {
+                                reportTryError(w, r, err, "Failed to run the code:\n"+message, hash)
+                        }
                         return
                 }
+
                 png, err := ioutil.ReadFile("../../../inout/" + hash + ".png")
                 if err != nil {
                         reportTryError(w, r, err, "Failed to open the generated PNG.", hash)
                         return
                 }
 
                 m := response{
                         Message: message,
                         Img:     base64.StdEncoding.EncodeToString([]byte(png)),
                         Hash:    hash,
@@ skipping 18 matching lines @@
         http.HandleFunc("/sources/", autogzip.HandleFunc(sourcesHandler))
 
         // Resources are served directly
         // TODO add support for caching/etags/gzip
         http.Handle("/res/", autogzip.Handle(http.FileServer(http.Dir("./"))))
 
         // TODO Break out /c/ as it's own handler.
         http.HandleFunc("/", autogzip.HandleFunc(mainHandler))
         log.Fatal(http.ListenAndServe(*port, nil))
 }