Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(544)

Issue 660563003: More effect->processor cleanup (Closed)

Created:
6 years, 2 months ago by bsalomon
Modified:
6 years, 2 months ago
Reviewers:
joshualitt, joshua.litt
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@comments
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : more #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -39 lines) Patch
M include/gpu/GrBackendProcessorFactory.h View 1 4 chunks +16 lines, -15 lines 0 comments Download
M include/gpu/GrProcessor.h View 1 chunk +4 lines, -4 lines 0 comments Download
M include/gpu/GrTBackendProcessorFactory.h View 1 2 chunks +19 lines, -19 lines 0 comments Download
M src/gpu/gl/GrGLProcessor.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
bsalomon
6 years, 2 months ago (2014-10-15 17:31:18 UTC) #1
joshua.litt
On 2014/10/15 17:31:18, bsalomon wrote: lgtm
6 years, 2 months ago (2014-10-15 17:45:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/660563003/20001
6 years, 2 months ago (2014-10-15 18:10:29 UTC) #4
commit-bot: I haz the power
6 years, 2 months ago (2014-10-15 18:25:25 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as b762cb548bbc260f9b6f3a816bd92e4b2c07df95

Powered by Google App Engine
This is Rietveld 408576698