Issue 660463002: DevTools: follow up to r183724, mark all floating components as roots.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 660463002: DevTools: follow up to r183724, mark all floating components as roots. (Closed)

Created:
6 years, 2 months ago by pfeldman

Modified:
6 years, 2 months ago

Reviewers:
apavlov

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

DevTools: follow up to r183724, mark all floating components as roots. BUG=417275 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183734

Patch Set 1 #

Patch Set 2 : #

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -3 lines)			Patch
M	Source/devtools/front_end/ui/DOMExtension.js	View		1 chunk	+7 lines, -0 lines	0 comments	Download
M	Source/devtools/front_end/ui/Popover.js	View		3 chunks	+4 lines, -2 lines	0 comments	Download
M	Source/devtools/front_end/ui/RootView.js	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/devtools/front_end/ui/View.js	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/660463002/20001

6 years, 2 months ago (2014-10-15 09:46:30 UTC) #5

commit-bot: I haz the power

6 years, 2 months ago (2014-10-15 10:48:21 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 (id:20001) as 183734

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages