Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1597)

Unified Diff: Source/devtools/front_end/ui/Popover.js

Issue 660463002: DevTools: follow up to r183724, mark all floating components as roots. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/devtools/front_end/ui/DOMExtension.js ('k') | Source/devtools/front_end/ui/RootView.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/ui/Popover.js
diff --git a/Source/devtools/front_end/ui/Popover.js b/Source/devtools/front_end/ui/Popover.js
index 289f11f914efbea5aa275c93d323377a80f291d0..4b564a3b751288b76228f32f7240289fc03766d9 100644
--- a/Source/devtools/front_end/ui/Popover.js
+++ b/Source/devtools/front_end/ui/Popover.js
@@ -37,7 +37,7 @@ WebInspector.Popover = function(popoverHelper)
{
WebInspector.View.call(this);
this.markAsRoot();
- this.element.className = "popover custom-popup-vertical-scroll custom-popup-horizontal-scroll"; // Override
+ this.element.className = WebInspector.Popover._classNamePrefix; // Override
this._containerElement = document.createElementWithClass("div", "fill popover-container");
this._popupArrowElement = this.element.createChild("div", "arrow");
@@ -47,6 +47,8 @@ WebInspector.Popover = function(popoverHelper)
this._hideBound = this.hide.bind(this);
}
+WebInspector.Popover._classNamePrefix = "popover component-root custom-popup-vertical-scroll custom-popup-horizontal-scroll";
+
WebInspector.Popover.prototype = {
/**
* @param {!Element} element
@@ -218,7 +220,7 @@ WebInspector.Popover.prototype = {
this._popupArrowElement.style.left += anchorBox.width / 2;
}
- this.element.className = "popover custom-popup-vertical-scroll custom-popup-horizontal-scroll " + verticalAlignment + "-" + horizontalAlignment + "-arrow";
+ this.element.className = WebInspector.Popover._classNamePrefix + " " + verticalAlignment + "-" + horizontalAlignment + "-arrow";
this.element.positionAt(newElementPosition.x - borderWidth, newElementPosition.y - borderWidth, container);
this.element.style.width = newElementPosition.width + borderWidth * 2 + "px";
this.element.style.height = newElementPosition.height + borderWidth * 2 + "px";
« no previous file with comments | « Source/devtools/front_end/ui/DOMExtension.js ('k') | Source/devtools/front_end/ui/RootView.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698