Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6068)

Unified Diff: chrome/common/mac/app_mode_common.h

Issue 66043003: Put app shim IPC socket in a temporary directory. (Mac) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Always use short socket path Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/mac/app_mode_common.h
diff --git a/chrome/common/mac/app_mode_common.h b/chrome/common/mac/app_mode_common.h
index de82e2450d33b2b74646edde0f16e0ef937ed86c..3b1d2bc384eee3a1bfa7459f61fa0ac271f3f7d8 100644
--- a/chrome/common/mac/app_mode_common.h
+++ b/chrome/common/mac/app_mode_common.h
@@ -127,6 +127,13 @@ struct ChromeAppModeInfo {
base::FilePath profile_dir;
};
+// IPC::kMaxSocketNameLength imposes a limit to the length of the path to a
tapted 2013/11/21 11:12:05 nit: I'd probably start this with `Due to kernel A
jackhou1 2013/11/22 00:20:40 Done.
+// socket. The app shim socket is stored in the user's home directory, so in
tapted 2013/11/21 11:12:05 nit: update comment (i.e. since there's no sockets
jackhou1 2013/11/22 00:20:40 Done.
+// tests and for users with long usernames, the full socket path cannot be used.
+// GetShortSocketPath hashes the full path and returns a path under /tmp that
+// can be used to make a symlink to the full path.
+base::FilePath GetShortSocketPath(const base::FilePath& full_path);
tapted 2013/11/21 11:12:05 maybe full_path -> user_data_dir?
jackhou1 2013/11/22 00:20:40 Done.
+
} // namespace app_mode
#endif // CHROME_COMMON_MAC_APP_MODE_COMMON_H_

Powered by Google App Engine
This is Rietveld 408576698