chrome/common/mac/app_mode_common.h - Issue 66043003: Put app shim IPC socket in a temporary directory. (Mac)

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/common/mac/app_mode_common.h

Issue 66043003: Put app shim IPC socket in a temporary directory. (Mac) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Always use short socket path Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« apps/app_shim/chrome_main_app_mode_mac.mm ('K') | « apps/app_shim/test/app_shim_host_manager_test_api_mac.cc ('k') | chrome/common/mac/app_mode_common.mm » ('j') | chrome/common/mac/app_mode_common.mm » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CHROME_COMMON_MAC_APP_MODE_COMMON_H_	5 #ifndef CHROME_COMMON_MAC_APP_MODE_COMMON_H_

6 #define CHROME_COMMON_MAC_APP_MODE_COMMON_H_	6 #define CHROME_COMMON_MAC_APP_MODE_COMMON_H_

7	7

8 #import <Foundation/Foundation.h>	8 #import <Foundation/Foundation.h>

9	9

10 #include "base/files/file_path.h"	10 #include "base/files/file_path.h"

(...skipping 109 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
120 // URL for the shortcut. Must be a valid URL.	120 // URL for the shortcut. Must be a valid URL.

121 std::string app_mode_url; // Required: v1.0	121 std::string app_mode_url; // Required: v1.0

122	122

123 // Path to the app's user data directory.	123 // Path to the app's user data directory.

124 base::FilePath user_data_dir;	124 base::FilePath user_data_dir;

125	125

126 // Directory of the profile associated with the app.	126 // Directory of the profile associated with the app.

127 base::FilePath profile_dir;	127 base::FilePath profile_dir;

128 };	128 };

129	129

	130 // IPC::kMaxSocketNameLength imposes a limit to the length of the path to a
	tapted 2013/11/21 11:12:05 nit: I'd probably start this with `Due to kernel A nit: I'd probably start this with `Due to kernel API restraints..` jackhou1 2013/11/22 00:20:40 Done. Show quoted text On 2013/11/21 11:12:05, tapted wrote: > nit: I'd probably start this with `Due to kernel API restraints..` Done.
	131 // socket. The app shim socket is stored in the user's home directory, so in
	tapted 2013/11/21 11:12:05 nit: update comment (i.e. since there's no sockets nit: update comment (i.e. since there's no sockets in the home dir any more) jackhou1 2013/11/22 00:20:40 Done. Show quoted text On 2013/11/21 11:12:05, tapted wrote: > nit: update comment (i.e. since there's no sockets in the home dir any more) Done.
	132 // tests and for users with long usernames, the full socket path cannot be used.

	133 // GetShortSocketPath hashes the full path and returns a path under /tmp that

	134 // can be used to make a symlink to the full path.

	135 base::FilePath GetShortSocketPath(const base::FilePath& full_path);
	tapted 2013/11/21 11:12:05 maybe full_path -> user_data_dir? maybe full_path -> user_data_dir? jackhou1 2013/11/22 00:20:40 Done. Show quoted text On 2013/11/21 11:12:05, tapted wrote: > maybe full_path -> user_data_dir? Done.
	136

130 } // namespace app_mode	137 } // namespace app_mode

131	138

132 #endif // CHROME_COMMON_MAC_APP_MODE_COMMON_H_	139 #endif // CHROME_COMMON_MAC_APP_MODE_COMMON_H_

OLD	NEW