Issue 660413002: Detach first letter pseudo element during RenderTextFragment destruction.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 660413002: Detach first letter pseudo element during RenderTextFragment destruction. (Closed)

Created:
6 years, 2 months ago by sof

Modified:
6 years, 2 months ago

Reviewers:
oilpan-reviews, dsinclair, haraken, esprehn

CC:
blink-reviews, blink-reviews-rendering, zoltan1, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, rune+blink

Base URL:
https://chromium.googlesource.com/chromium/blink.git/+/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Detach first letter pseudo element during RenderTextFragment destruction. If the RenderTextFragment is being destroyed, make sure the pseudo element is unlinked (Oilpan or not) during destroy() instead. R=haraken BUG=391288 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183943

Patch Set 1 #

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -2 lines)			Patch
	M	Source/core/rendering/RenderTextFragment.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	Source/core/rendering/RenderTextFragment.cpp	View		1 chunk	+6 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

sof

Please take a look. Following up on https://codereview.chromium.org/659953004/

6 years, 2 months ago (2014-10-18 06:23:10 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/660413002/1

6 years, 2 months ago (2014-10-18 12:09:15 UTC) #5

commit-bot: I haz the power

6 years, 2 months ago (2014-10-18 12:12:35 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as 183943

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages