Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Unified Diff: Source/core/rendering/RenderTextFragment.cpp

Issue 660413002: Detach first letter pseudo element during RenderTextFragment destruction. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git/+/master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/rendering/RenderTextFragment.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/rendering/RenderTextFragment.cpp
diff --git a/Source/core/rendering/RenderTextFragment.cpp b/Source/core/rendering/RenderTextFragment.cpp
index bd640c89a748e7a4e90af8562ddf5966f95310c1..b1157c9b8bf83e91643ed6e060c83595d4367557 100644
--- a/Source/core/rendering/RenderTextFragment.cpp
+++ b/Source/core/rendering/RenderTextFragment.cpp
@@ -53,11 +53,15 @@ RenderTextFragment::RenderTextFragment(Node* node, StringImpl* str)
RenderTextFragment::~RenderTextFragment()
{
-#if !ENABLE(OILPAN)
+ ASSERT(!m_firstLetterPseudoElement);
+}
+
+void RenderTextFragment::destroy()
+{
if (m_isRemainingTextRenderer && m_firstLetterPseudoElement)
m_firstLetterPseudoElement->setRemainingTextRenderer(nullptr);
m_firstLetterPseudoElement = nullptr;
-#endif
+ RenderText::destroy();
}
void RenderTextFragment::trace(Visitor* visitor)
« no previous file with comments | « Source/core/rendering/RenderTextFragment.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698