[NaCl SDK] nacl_io: Fix utime() on directories.

[NaCl SDK] nacl_io: Fix utime() on directories.

It was previously failing with EISDIR. This is because
utime() internally acquires the node as O_WRONLY in
order to call the Futimens method.  This was failing
because the check for opening a directory for write
was done in Open() rather than CanOpen().

Committed: https://crrev.com/9664c614f4d853fd7887fcb4d8249183a1169f0e
Cr-Commit-Position: refs/heads/master@{#300313}

[Sam Clegg, 2014-10-20 17:12:47]

sbc@chromium.org changed reviewers:
+ binji@chromium.org

[Sam Clegg, 2014-10-20 17:14:44]

I could split this change in two if you perfer?

[bradn, 2014-10-20 17:17:34]

bradnelson@google.com changed reviewers:
+ bradnelson@google.com

[bradn, 2014-10-20 17:17:34]

LGTM

But I relatively strongly think you should add a constant for 0777 in node.h,
but probably not use it in the tests.

https://codereview.chromium.org/660353003/diff/1/native_client_sdk/src/librar...
File native_client_sdk/src/libraries/nacl_io/fusefs/fuse_fs.cc (right):

https://codereview.chromium.org/660353003/diff/1/native_client_sdk/src/librar...
native_client_sdk/src/libraries/nacl_io/fusefs/fuse_fs.cc:105: mode =
statbuf.st_mode & 0777;
So we're explicitly excluding things like suid?

https://codereview.chromium.org/660353003/diff/1/native_client_sdk/src/librar...
File native_client_sdk/src/libraries/nacl_io/kernel_handle.cc (right):

https://codereview.chromium.org/660353003/diff/1/native_client_sdk/src/librar...
native_client_sdk/src/libraries/nacl_io/kernel_handle.cc:48: if ((open_flags &
3) != O_RDONLY && node_->IsaDir()) {
There no constant for  the 3?j

[Sam Clegg, 2014-10-20 17:36:16]

Split out the mode bits change into a separate CL

https://codereview.chromium.org/660353003/diff/1/native_client_sdk/src/librar...
File native_client_sdk/src/libraries/nacl_io/kernel_handle.cc (right):

https://codereview.chromium.org/660353003/diff/1/native_client_sdk/src/librar...
native_client_sdk/src/libraries/nacl_io/kernel_handle.cc:48: if ((open_flags &
3) != O_RDONLY && node_->IsaDir()) {
On 2014/10/20 17:17:34, bradn wrote:
> There no constant for  the 3?j
Not that I could find.

[bradn, 2014-10-20 17:44:21]

lgtm

[binji, 2014-10-20 18:03:24]

lgtm

[Sam Clegg, 2014-10-20 18:30:25]

The CQ bit was checked by sbc@chromium.org

[commit-bot: I haz the power, 2014-10-20 18:31:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/660353003/40001

[commit-bot: I haz the power, 2014-10-20 19:29:45]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2014-10-20 19:30:48]

Patchset 3 (id:??) landed as
https://crrev.com/9664c614f4d853fd7887fcb4d8249183a1169f0e
Cr-Commit-Position: refs/heads/master@{#300313}