native_client_sdk/src/libraries/nacl_io/kernel_proxy.cc - Issue 660353003: [NaCl SDK] nacl_io: Fix utime() on directories.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: native_client_sdk/src/libraries/nacl_io/kernel_proxy.cc

Issue 660353003: [NaCl SDK] nacl_io: Fix utime() on directories. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: native_client_sdk/src/libraries/nacl_io/kernel_proxy.cc

diff --git a/native_client_sdk/src/libraries/nacl_io/kernel_proxy.cc b/native_client_sdk/src/libraries/nacl_io/kernel_proxy.cc

index 89c8e36db7c341a23eb96d91b6443092d7851d67..0837647e566a7c19882485d665e2271d4ab07bbe 100644

--- a/native_client_sdk/src/libraries/nacl_io/kernel_proxy.cc

+++ b/native_client_sdk/src/libraries/nacl_io/kernel_proxy.cc

@@ -792,6 +792,11 @@ int KernelProxy::truncate(const char* path, off_t len) {

return -1;

}

+ // Directories cannot be truncated.

+ if (node->IsaDir()) {

+ return EISDIR;

+ }

if (!node->CanOpen(O_WRONLY)) {

errno = EACCES;

return -1;