chrome/browser/media_galleries/media_scan_manager.h - Issue 660343006: Standardize usage of virtual/override/final in chrome/browser/media_galleries

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/media_galleries/media_scan_manager.h

Issue 660343006: Standardize usage of virtual/override/final in chrome/browser/media_galleries (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/media_galleries/media_gallery_context_menu.h ('k') | chrome/browser/media_galleries/media_scan_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/media_galleries/media_scan_manager.h

diff --git a/chrome/browser/media_galleries/media_scan_manager.h b/chrome/browser/media_galleries/media_scan_manager.h

index 80509ce0e20f82202ec690bfc30bdb128fb8ae2b..bbfc10cdf522677ba836498c4c9b3e92e8210c98 100644

--- a/chrome/browser/media_galleries/media_scan_manager.h

+++ b/chrome/browser/media_galleries/media_scan_manager.h

@@ -34,7 +34,7 @@ class ExtensionRegistry;

class MediaScanManager : public extensions::ExtensionRegistryObserver {

public:

MediaScanManager();

- virtual ~MediaScanManager();

+ ~MediaScanManager() override;

// There can only be ever one observer registered per profile. Does not take

// ownership of |observer|. An observer must be registered before scanning.

@@ -76,7 +76,7 @@ class MediaScanManager : public extensions::ExtensionRegistryObserver {

typedef std::map<Profile*, ScanObservers> ScanObserverMap;

// extensions::ExtensionRegistryObserver implementation.

- virtual void OnExtensionUnloaded(

+ void OnExtensionUnloaded(

content::BrowserContext* browser_context,

const extensions::Extension* extension,

extensions::UnloadedExtensionInfo::Reason reason) override;