chrome/browser/media_galleries/media_gallery_context_menu.h - Issue 660343006: Standardize usage of virtual/override/final in chrome/browser/media_galleries

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/media_galleries/media_gallery_context_menu.h

Issue 660343006: Standardize usage of virtual/override/final in chrome/browser/media_galleries (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/media_galleries/media_galleries_scan_result_controller.h ('k') | chrome/browser/media_galleries/media_scan_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/media_galleries/media_gallery_context_menu.h

diff --git a/chrome/browser/media_galleries/media_gallery_context_menu.h b/chrome/browser/media_galleries/media_gallery_context_menu.h

index 0c87f90ca1498206fd78c417dc2433c0f98c9d8d..05fcf994e0efd43ad08da1409b79514dec497639 100644

--- a/chrome/browser/media_galleries/media_gallery_context_menu.h

+++ b/chrome/browser/media_galleries/media_gallery_context_menu.h

@@ -17,19 +17,19 @@ class MediaGalleryContextMenu : public ui::SimpleMenuModel,

ForgetGalleryCallback;

explicit MediaGalleryContextMenu(const ForgetGalleryCallback& callback);

- virtual ~MediaGalleryContextMenu();

+ ~MediaGalleryContextMenu() override;

void set_pref_id(MediaGalleryPrefId pref_id) {

pref_id_ = pref_id;

}

// ui::SimpleMenuModel::Delegate overrides:

- virtual bool IsCommandIdChecked(int command_id) const override;

- virtual bool IsCommandIdEnabled(int command_id) const override;

- virtual bool IsCommandIdVisible(int command_id) const override;

- virtual bool GetAcceleratorForCommandId(

- int command_id, ui::Accelerator* accelerator) override;

- virtual void ExecuteCommand(int command_id, int event_flags) override;

+ bool IsCommandIdChecked(int command_id) const override;

+ bool IsCommandIdEnabled(int command_id) const override;

+ bool IsCommandIdVisible(int command_id) const override;

+ bool GetAcceleratorForCommandId(int command_id,

+ ui::Accelerator* accelerator) override;

+ void ExecuteCommand(int command_id, int event_flags) override;

private:

MediaGalleryPrefId pref_id_;