chrome/browser/media_galleries/fileapi/mtp_file_stream_reader.h - Issue 660343006: Standardize usage of virtual/override/final in chrome/browser/media_galleries

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/media_galleries/fileapi/mtp_file_stream_reader.h

Issue 660343006: Standardize usage of virtual/override/final in chrome/browser/media_galleries (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/media_galleries/fileapi/media_file_validator_factory.cc ('k') | chrome/browser/media_galleries/fileapi/native_media_file_util.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/media_galleries/fileapi/mtp_file_stream_reader.h

diff --git a/chrome/browser/media_galleries/fileapi/mtp_file_stream_reader.h b/chrome/browser/media_galleries/fileapi/mtp_file_stream_reader.h

index 7fcfcacfe0d535ceff482c116c3ffff4686bb840..59ba5cbd6f42f3dced4979a3cd39754b94ffca61 100644

--- a/chrome/browser/media_galleries/fileapi/mtp_file_stream_reader.h

+++ b/chrome/browser/media_galleries/fileapi/mtp_file_stream_reader.h

@@ -30,13 +30,13 @@ class MTPFileStreamReader

const base::Time& expected_modification_time,

bool do_media_header_validation);

- virtual ~MTPFileStreamReader();

+ ~MTPFileStreamReader() override;

// FileStreamReader overrides.

- virtual int Read(net::IOBuffer* buf, int buf_len,

- const net::CompletionCallback& callback) override;

- virtual int64 GetLength(

- const net::Int64CompletionCallback& callback) override;

+ int Read(net::IOBuffer* buf,

+ int buf_len,

+ const net::CompletionCallback& callback) override;

+ int64 GetLength(const net::Int64CompletionCallback& callback) override;

private:

void FinishValidateMediaHeader(