chrome/browser/media_galleries/fileapi/media_file_validator_factory.cc - Issue 660343006: Standardize usage of virtual/override/final in chrome/browser/media_galleries

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/media_galleries/fileapi/media_file_validator_factory.cc

Issue 660343006: Standardize usage of virtual/override/final in chrome/browser/media_galleries (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/media_galleries/fileapi/media_file_validator_factory.h ('k') | chrome/browser/media_galleries/fileapi/mtp_file_stream_reader.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/media_galleries/fileapi/media_file_validator_factory.cc

diff --git a/chrome/browser/media_galleries/fileapi/media_file_validator_factory.cc b/chrome/browser/media_galleries/fileapi/media_file_validator_factory.cc

index 5965eb7f22577bdf35bc0785caacf76018ebb877..608f49f75c49435849cf4464a07bc9e5009a5dfa 100644

--- a/chrome/browser/media_galleries/fileapi/media_file_validator_factory.cc

+++ b/chrome/browser/media_galleries/fileapi/media_file_validator_factory.cc

@@ -14,14 +14,14 @@ namespace {

class InvalidFileValidator : public storage::CopyOrMoveFileValidator {

public:

- virtual ~InvalidFileValidator() {}

- virtual void StartPreWriteValidation(

+ ~InvalidFileValidator() override {}

+ void StartPreWriteValidation(

const storage::CopyOrMoveFileValidator::ResultCallback& result_callback)

override {

result_callback.Run(base::File::FILE_ERROR_SECURITY);

}

- virtual void StartPostWriteValidation(

+ void StartPostWriteValidation(

const base::FilePath& dest_platform_path,

const storage::CopyOrMoveFileValidator::ResultCallback& result_callback)

override {