Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 660343002: Look for Owner key in both private and public slots (Closed)

Created:
6 years, 2 months ago by Chris Masone
Modified:
6 years, 2 months ago
Reviewers:
stevenjb, ygorshenin1
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git/+/master
Project:
chromium
Visibility:
Public.

Description

Look for Owner key in both private and public slots As a part of migrating away from NSS, CrOS is going to start generating the device Owner keypair using Chaps, which is exposed to the browser via the TPM-backed PK11 token that gets loaded into each user's private NSS PK11 slot. To support the current mode of operation as well as the new, make OwnerSettingsServiceChromeOS check both slots for the key. BUG=422036 TEST=unit test, ownership autotests R=stevenjb Committed: https://crrev.com/c19bb4deef7aa916cbfb3d4fbbb5e7f85c19ce6b Cr-Commit-Position: refs/heads/master@{#300292}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -3 lines) Patch
M chrome/browser/chromeos/ownership/owner_settings_service_chromeos.cc View 1 chunk +14 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/settings/device_settings_service_unittest.cc View 1 chunk +36 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Chris Masone
Steven, I think you're an OWNER of this code? I can find someone else to ...
6 years, 2 months ago (2014-10-17 20:14:30 UTC) #1
stevenjb
+ygorshenin@ who is the owner for c/b/chromeos/ownership (which I am not familiar with) owner lgtm ...
6 years, 2 months ago (2014-10-20 16:02:47 UTC) #3
ygorshenin1
chrome/browser/chromeos/ownership/ lgtm.
6 years, 2 months ago (2014-10-20 17:10:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/660343002/1
6 years, 2 months ago (2014-10-20 17:26:33 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-20 17:38:57 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-20 17:39:37 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c19bb4deef7aa916cbfb3d4fbbb5e7f85c19ce6b
Cr-Commit-Position: refs/heads/master@{#300292}

Powered by Google App Engine
This is Rietveld 408576698