Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Side by Side Diff: chrome/browser/chromeos/settings/device_settings_service_unittest.cc

Issue 660343002: Look for Owner key in both private and public slots (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git/+/master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/chromeos/ownership/owner_settings_service_chromeos.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/chromeos/settings/device_settings_service.h" 5 #include "chrome/browser/chromeos/settings/device_settings_service.h"
6 6
7 #include "base/basictypes.h" 7 #include "base/basictypes.h"
8 #include "base/bind.h" 8 #include "base/bind.h"
9 #include "base/bind_helpers.h" 9 #include "base/bind_helpers.h"
10 #include "base/compiler_specific.h" 10 #include "base/compiler_specific.h"
(...skipping 513 matching lines...) Expand 10 before | Expand all | Expand 10 after
524 ASSERT_TRUE(device_settings_service_.GetPublicKey()->is_loaded()); 524 ASSERT_TRUE(device_settings_service_.GetPublicKey()->is_loaded());
525 ASSERT_TRUE(device_policy_.GetSigningKey()->ExportPublicKey(&key)); 525 ASSERT_TRUE(device_policy_.GetSigningKey()->ExportPublicKey(&key));
526 EXPECT_EQ(device_settings_service_.GetPublicKey()->data(), key); 526 EXPECT_EQ(device_settings_service_.GetPublicKey()->data(), key);
527 EXPECT_FALSE(device_settings_service_.HasPrivateOwnerKey()); 527 EXPECT_FALSE(device_settings_service_.HasPrivateOwnerKey());
528 EXPECT_EQ(DeviceSettingsService::OWNERSHIP_TAKEN, 528 EXPECT_EQ(DeviceSettingsService::OWNERSHIP_TAKEN,
529 device_settings_service_.GetOwnershipStatus()); 529 device_settings_service_.GetOwnershipStatus());
530 EXPECT_TRUE(is_owner_set_); 530 EXPECT_TRUE(is_owner_set_);
531 EXPECT_FALSE(is_owner_); 531 EXPECT_FALSE(is_owner_);
532 } 532 }
533 533
534 TEST_F(DeviceSettingsServiceTest, OwnerPrivateKeyInTPMToken) {
535 owner_key_util_->Clear();
536
537 EXPECT_FALSE(device_settings_service_.HasPrivateOwnerKey());
538 EXPECT_FALSE(device_settings_service_.GetPublicKey().get());
539 EXPECT_EQ(DeviceSettingsService::OWNERSHIP_UNKNOWN,
540 device_settings_service_.GetOwnershipStatus());
541
542 const std::string& user_id = device_policy_.policy_data().username();
543 owner_key_util_->SetPublicKeyFromPrivateKey(*device_policy_.GetSigningKey());
544 InitOwner(user_id, false);
545 OwnerSettingsServiceChromeOS* service =
546 OwnerSettingsServiceChromeOSFactory::GetForProfile(profile_.get());
547 ASSERT_TRUE(service);
548 ReloadDeviceSettings();
549
550 EXPECT_FALSE(device_settings_service_.HasPrivateOwnerKey());
551 ASSERT_TRUE(device_settings_service_.GetPublicKey().get());
552 ASSERT_TRUE(device_settings_service_.GetPublicKey()->is_loaded());
553 std::vector<uint8> key;
554 ASSERT_TRUE(device_policy_.GetSigningKey()->ExportPublicKey(&key));
555 EXPECT_EQ(device_settings_service_.GetPublicKey()->data(), key);
556 EXPECT_EQ(DeviceSettingsService::OWNERSHIP_TAKEN,
557 device_settings_service_.GetOwnershipStatus());
558
559 owner_key_util_->SetPrivateKey(device_policy_.GetSigningKey());
560 service->OnTPMTokenReady(true /* is ready */);
561 FlushDeviceSettings();
562
563 EXPECT_TRUE(device_settings_service_.HasPrivateOwnerKey());
564 ASSERT_TRUE(device_settings_service_.GetPublicKey().get());
565 ASSERT_TRUE(device_settings_service_.GetPublicKey()->is_loaded());
566 ASSERT_TRUE(device_policy_.GetSigningKey()->ExportPublicKey(&key));
567 EXPECT_EQ(device_settings_service_.GetPublicKey()->data(), key);
568 }
569
534 TEST_F(DeviceSettingsServiceTest, OnTPMTokenReadyForOwner) { 570 TEST_F(DeviceSettingsServiceTest, OnTPMTokenReadyForOwner) {
535 owner_key_util_->Clear(); 571 owner_key_util_->Clear();
536 572
537 EXPECT_FALSE(device_settings_service_.HasPrivateOwnerKey()); 573 EXPECT_FALSE(device_settings_service_.HasPrivateOwnerKey());
538 EXPECT_FALSE(device_settings_service_.GetPublicKey().get()); 574 EXPECT_FALSE(device_settings_service_.GetPublicKey().get());
539 EXPECT_EQ(DeviceSettingsService::OWNERSHIP_UNKNOWN, 575 EXPECT_EQ(DeviceSettingsService::OWNERSHIP_UNKNOWN,
540 device_settings_service_.GetOwnershipStatus()); 576 device_settings_service_.GetOwnershipStatus());
541 577
542 const std::string& user_id = device_policy_.policy_data().username(); 578 const std::string& user_id = device_policy_.policy_data().username();
543 owner_key_util_->SetPublicKeyFromPrivateKey(*device_policy_.GetSigningKey()); 579 owner_key_util_->SetPublicKeyFromPrivateKey(*device_policy_.GetSigningKey());
(...skipping 100 matching lines...) Expand 10 before | Expand all | Expand 10 after
644 EXPECT_CALL(observer_, OwnershipStatusChanged()).Times(0); 680 EXPECT_CALL(observer_, OwnershipStatusChanged()).Times(0);
645 EXPECT_CALL(observer_, DeviceSettingsUpdated()).Times(1); 681 EXPECT_CALL(observer_, DeviceSettingsUpdated()).Times(1);
646 device_settings_service_.PropertyChangeComplete(true); 682 device_settings_service_.PropertyChangeComplete(true);
647 FlushDeviceSettings(); 683 FlushDeviceSettings();
648 Mock::VerifyAndClearExpectations(&observer_); 684 Mock::VerifyAndClearExpectations(&observer_);
649 685
650 device_settings_service_.RemoveObserver(&observer_); 686 device_settings_service_.RemoveObserver(&observer_);
651 } 687 }
652 688
653 } // namespace chromeos 689 } // namespace chromeos
OLDNEW
« no previous file with comments | « chrome/browser/chromeos/ownership/owner_settings_service_chromeos.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698