Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Unified Diff: chrome/browser/autocomplete/autocomplete_popup_view_mac.mm

Issue 6602070: Port autocomplete_edit_view_browsertest.cc to Mac. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix PrimarySelection test. Created 9 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/autocomplete/autocomplete_popup_view_mac.mm
diff --git a/chrome/browser/autocomplete/autocomplete_popup_view_mac.mm b/chrome/browser/autocomplete/autocomplete_popup_view_mac.mm
index 48afd85b79a1e84e125d63c69761e0e2d3f33d39..023d934c71f4ae4a3c8ab24756eb4ebf4dd0f4be 100644
--- a/chrome/browser/autocomplete/autocomplete_popup_view_mac.mm
+++ b/chrome/browser/autocomplete/autocomplete_popup_view_mac.mm
@@ -319,7 +319,7 @@ AutocompleteMatrix* AutocompletePopupViewMac::GetAutocompleteMatrix() {
}
bool AutocompletePopupViewMac::IsOpen() const {
- return [popup_ isVisible] ? true : false;
+ return popup_ != nil;
}
void AutocompletePopupViewMac::CreatePopupIfNeeded() {
@@ -409,7 +409,7 @@ void AutocompletePopupViewMac::PositionPopup(const CGFloat matrixHeight) {
[popup_ setAnimations:savedAnimations];
}
- if (!IsOpen())
+ if (![popup_ isVisible])
[[field_ window] addChildWindow:popup_ ordered:NSWindowAbove];
}

Powered by Google App Engine
This is Rietveld 408576698