Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Unified Diff: chrome/browser/autocomplete/autocomplete_edit_view_mac.mm

Issue 6602070: Port autocomplete_edit_view_browsertest.cc to Mac. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix PrimarySelection test. Created 9 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/autocomplete/autocomplete_edit_view_mac.mm
diff --git a/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm b/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm
index 9af6904f7a8adff8e15b4bbed9dbf9bcdf725bb6..815cb2d738add7b46d4f89feb5c914500d2cb0a2 100644
--- a/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm
+++ b/chrome/browser/autocomplete/autocomplete_edit_view_mac.mm
@@ -746,7 +746,9 @@ bool AutocompleteEditViewMac::IsImeComposing() const {
void AutocompleteEditViewMac::OnDidBeginEditing() {
// We should only arrive here when the field is focussed.
DCHECK([field_ currentEditor]);
+}
+void AutocompleteEditViewMac::OnBeforeChange() {
// Capture the current state.
OnBeforePossibleChange();
}
@@ -754,9 +756,6 @@ void AutocompleteEditViewMac::OnDidBeginEditing() {
void AutocompleteEditViewMac::OnDidChange() {
// Figure out what changed and notify the model_.
OnAfterPossibleChange();
-
- // Then capture the new state.
- OnBeforePossibleChange();
}
void AutocompleteEditViewMac::OnDidEndEditing() {
@@ -887,10 +886,6 @@ bool AutocompleteEditViewMac::OnDoCommandBySelector(SEL cmd) {
}
}
- // Capture the state before the operation changes the content.
- // TODO(shess): Determine if this is always redundent WRT the call
- // in -controlTextDidChange:.
- OnBeforePossibleChange();
return false;
}
« no previous file with comments | « chrome/browser/autocomplete/autocomplete_edit_view_mac.h ('k') | chrome/browser/autocomplete/autocomplete_popup_view_mac.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698