Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(904)

Unified Diff: third_party/WebKit/WebCore/rendering/RenderView.cpp

Issue 66019: Fix uninitialized memory read. This is a temporary patch until the bugs in th... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/WebCore/rendering/RenderView.cpp
===================================================================
--- third_party/WebKit/WebCore/rendering/RenderView.cpp (revision 13377)
+++ third_party/WebKit/WebCore/rendering/RenderView.cpp (working copy)
@@ -51,6 +51,15 @@
, m_layoutState(0)
, m_layoutStateDisableCount(0)
{
+ // TODO(brettw): This change is at the suggestion of Hyatt. It fixes an
+ // uninitialized memory read. It was fixed in:
+ // http://trac.webkit.org/changeset/42334 and
+ // http://trac.webkit.org/changeset/42336
+ // but those changes broke Gmail. So this change is temporary until we
+ // merge to a good revision with it fixed.
+ m_docHeight = 0;
+ m_docWidth = 0;
+
// Clear our anonymous bit, set because RenderObject assumes
// any renderer with document as the node is anonymous.
setIsAnonymous(false);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698