Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Side by Side Diff: third_party/WebKit/WebCore/rendering/RenderView.cpp

Issue 66019: Fix uninitialized memory read. This is a temporary patch until the bugs in th... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserv ed. 3 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserv ed.
4 * 4 *
5 * This library is free software; you can redistribute it and/or 5 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Library General Public 6 * modify it under the terms of the GNU Library General Public
7 * License as published by the Free Software Foundation; either 7 * License as published by the Free Software Foundation; either
8 * version 2 of the License, or (at your option) any later version. 8 * version 2 of the License, or (at your option) any later version.
9 * 9 *
10 * This library is distributed in the hope that it will be useful, 10 * This library is distributed in the hope that it will be useful,
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
44 , m_frameView(view) 44 , m_frameView(view)
45 , m_selectionStart(0) 45 , m_selectionStart(0)
46 , m_selectionEnd(0) 46 , m_selectionEnd(0)
47 , m_selectionStartPos(-1) 47 , m_selectionStartPos(-1)
48 , m_selectionEndPos(-1) 48 , m_selectionEndPos(-1)
49 , m_printImages(true) 49 , m_printImages(true)
50 , m_maximalOutlineSize(0) 50 , m_maximalOutlineSize(0)
51 , m_layoutState(0) 51 , m_layoutState(0)
52 , m_layoutStateDisableCount(0) 52 , m_layoutStateDisableCount(0)
53 { 53 {
54 // TODO(brettw): This change is at the suggestion of Hyatt. It fixes an
55 // uninitialized memory read. It was fixed in:
56 // http://trac.webkit.org/changeset/42334 and
57 // http://trac.webkit.org/changeset/42336
58 // but those changes broke Gmail. So this change is temporary until we
59 // merge to a good revision with it fixed.
60 m_docHeight = 0;
61 m_docWidth = 0;
62
54 // Clear our anonymous bit, set because RenderObject assumes 63 // Clear our anonymous bit, set because RenderObject assumes
55 // any renderer with document as the node is anonymous. 64 // any renderer with document as the node is anonymous.
56 setIsAnonymous(false); 65 setIsAnonymous(false);
57 66
58 // init RenderObject attributes 67 // init RenderObject attributes
59 setInline(false); 68 setInline(false);
60 69
61 m_minPrefWidth = 0; 70 m_minPrefWidth = 0;
62 m_maxPrefWidth = 0; 71 m_maxPrefWidth = 0;
63 72
(...skipping 621 matching lines...) Expand 10 before | Expand all | Expand 10 after
685 void RenderView::willMoveOffscreen() 694 void RenderView::willMoveOffscreen()
686 { 695 {
687 #if USE(ACCELERATED_COMPOSITING) 696 #if USE(ACCELERATED_COMPOSITING)
688 if (m_compositor) 697 if (m_compositor)
689 m_compositor->willMoveOffscreen(); 698 m_compositor->willMoveOffscreen();
690 #endif 699 #endif
691 } 700 }
692 701
693 } // namespace WebCore 702 } // namespace WebCore
694 703
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698