Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1276)

Unified Diff: sandbox/linux/bpf_dsl/bpf_dsl.cc

Issue 660153002: bpf_dsl: move more implementation details out of bpf_dsl.h (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git/+/master
Patch Set: IWYU Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sandbox/linux/bpf_dsl/bpf_dsl.h ('k') | sandbox/linux/bpf_dsl/bpf_dsl_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sandbox/linux/bpf_dsl/bpf_dsl.cc
diff --git a/sandbox/linux/bpf_dsl/bpf_dsl.cc b/sandbox/linux/bpf_dsl/bpf_dsl.cc
index f29aeec609825db3a6e7ae80952018d5d98fe9a6..ffabeac6da5464ce27b8fe2cf117296e7ed73b11 100644
--- a/sandbox/linux/bpf_dsl/bpf_dsl.cc
+++ b/sandbox/linux/bpf_dsl/bpf_dsl.cc
@@ -13,7 +13,6 @@
#include "sandbox/linux/bpf_dsl/bpf_dsl_impl.h"
#include "sandbox/linux/bpf_dsl/policy_compiler.h"
#include "sandbox/linux/seccomp-bpf/errorcode.h"
-#include "sandbox/linux/seccomp-bpf/syscall_iterator.h"
namespace sandbox {
namespace bpf_dsl {
@@ -377,26 +376,6 @@ ResultExpr SandboxBPFDSLPolicy::InvalidSyscall() const {
return Error(ENOSYS);
}
-ErrorCode SandboxBPFDSLPolicy::EvaluateSyscall(PolicyCompiler* pc,
- int sysno) const {
- return EvaluateSyscall(sysno)->Compile(pc);
-}
-
-ErrorCode SandboxBPFDSLPolicy::InvalidSyscall(PolicyCompiler* pc) const {
- return InvalidSyscall()->Compile(pc);
-}
-
-bool SandboxBPFDSLPolicy::HasUnsafeTraps() const {
- for (SyscallIterator iter(false); !iter.Done();) {
- uint32_t sysnum = iter.Next();
- if (SyscallIterator::IsValid(sysnum) &&
- EvaluateSyscall(sysnum)->HasUnsafeTraps()) {
- return true;
- }
- }
- return InvalidSyscall()->HasUnsafeTraps();
-}
-
ResultExpr SandboxBPFDSLPolicy::Trap(TrapRegistry::TrapFnc trap_func,
const void* aux) {
return bpf_dsl::Trap(trap_func, aux);
« no previous file with comments | « sandbox/linux/bpf_dsl/bpf_dsl.h ('k') | sandbox/linux/bpf_dsl/bpf_dsl_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698